Use log4j for unit tests #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@pietrygamat disregard the log4j struggles, I've resolved them. Do still feel free to customize the PR though. |
hiddenalpha
reviewed
Dec 1, 2023
pietrygamat
reviewed
Dec 1, 2023
tresf
commented
Dec 8, 2023
tresf
commented
Dec 8, 2023
tresf
commented
Dec 8, 2023
pietrygamat
force-pushed
the
test-logging
branch
from
31869b7 to
c6c8969
Compare
pietrygamat
reviewed
Dec 9, 2023
pietrygamat
force-pushed
the
test-logging
branch
from
99253c4 to
9b88da9
Compare
|
@pietrygamat thank you for the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
Potentially supersedes #158
Closes #156