Sonify plugin updates jtedits #21
Open
+1,628
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-trayford
force-pushed
the
sonify-plugin-updates-jtedits
branch
from
81d6101 to
49520a8
Compare
…pacetelescope#3337) * handle 1 source edge case, implement max sources for all catalog types, test coverage * add change log, remove unused line * move redudant Gaia code for max sources * add snackbar message when max_sources used * add Gaia and update SDSS test coverage * resolve test failure * ignore gaia scheduled maintenance stdout * take 2 suppress stdout * ignore Gaia test warning * consolidate all catalogs adding to table, address GAIA 1 max_source * resolve test failure * move comment
…eractive_regions and get_spectral_regions (spacetelescope#3340) * new get subset method * rename to get_regions * . * test * link follow up issue when trying to use import_region instead of apply_interactive_region * remove _obj when using get_regions * add get_regions to doc * addl review
* Track loaded mask cube in cubeviz * Don't save DQ array as loaded_mask for JWST * Add extraction test on file with mask * Codestyle * Add consideration of loaded mask to aperture weight mask * Remove duplicate test, codestyle * Changelog * Update jdaviz/configs/cubeviz/plugins/tests/test_parsers.py Co-authored-by: P. L. Lim <[email protected]> * Cast this as bool here * Fix tests, address review comments * adding regression tests to manga mask * Update jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.py Co-authored-by: Brett M. Morris <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> Co-authored-by: Brett M. Morris <[email protected]> Co-authored-by: Brett M. Morris <[email protected]>
…e#3363) * Don't loop through all subsets in get_subset if one is requested, act on lowercase labels * Don't mess with lowercasing labels * get rid of debugging prints * Add changelog * Move name check to start, sort printed list in error * Update jdaviz/app.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/app.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]>
…ope#3336) * helper method to programmatically toggle API hints * update plugin-hint toggle description * fix tests
Add test and change log. Test was proven to fail on main locally.
… angle (spacetelescope#3343) * ensure specutils has access to custom eqvs and update targ solid angle bug * fix spacing syntax error * add spec axis/pixar_sr eqvs to model fit, add test coverage * add change log * add indirect conversion handling for PIX2 and test coverage
* fix type issue * . * revert some changes
* Create audified cube and use with spectrum at spaxel tool * Add Sonify Data plugin and connect to spectrum per spaxel tool * Fix errors * Try moving code to mixin * Move code to viewers.py * Remove print statements * Patches: - Fix sigcube alignment with other cubes [get rid of transpose] - Add percentile cut option that enables some rough feature isolation without full continuum subtraction - Protect against cubes w/NaNs * fix np import * add audio frequency range choice and equal loudness normalisation options * Create dropdown to select output sound device * Various updates and QOL improvements * Connect volume level in viewer to sonify plugin * add volume attenuation functionality * add sound device switching * feed ELN flag to Image Viewer * Enable start stop stream and strauss soft dependency * Add note to plugin when strauss is not downloaded * Add strauss as soft dependency * Get build devices method working on windows * ensure sound generation always uses the current spectrum-at-spaxel wl range * post rebase clean-up (remove prints and rogue spaces) * this syntax seems to work to install strauss on our specific git branch for now, while awaitin PyPI release * Update code to be PEP8 * PEP8 fixes * Remove old code * Fix test * Fix test 2 * Update docs link in plugin * Use spectral subset for range and move advanced options to accordion * fix volume bug (doesn't crash on vol=0) * Rearrange order in plugin * Fix code style * Remove unused import * Add documentation and a test * Add install instructions to warning when package is not present * Fix test failure * Add plugin description * Add plugin description * Finish test and add standalone hook * Grey out start/stop stream and fix code style * Update docs and change disable message for plugin without strauss installed * Update jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py Co-authored-by: Ricky O'Steen <[email protected]> * Add cron job for strauss * Add strauss deps to tox.ini * Add sounddevice as dependency * Add port audio dep * Try manually adding install for libportaudio2 * Try different order and Python version * not a Python package * Catch case with no sound devices and set plugin to disabled * catch no sound device case without errors in other cases, also remove tqdm use and import, and use main branch strauss which should now work for JDAViz! * Fix check for sound devices * i needed these quotes for the pip suggestion to work * remove debug print * Fix codestyle and stop sonify plugin test running on CI * Add test that can run on CI * add test to run with CI * Prevent running sonify cube method if disabled_msg is set * Use pytest for conditional * Update test_sonify_data.py * Add change log entry * Addres review comments * Replace audif- with sonif- * Change install instructions to pip install strauss --------- Co-authored-by: James Trayford <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]> Co-authored-by: P. L. Lim <[email protected]>
* allow manual_options to be filter * manual options can be either strings or dictionaries * filters passed to SelectPluginComponent will act on manual items, classes that subclass SelectPluginComponent may choose to ALWAYS include all manual items, ignoring filters * FileImportSelect icon support * use JWST and Roman footprint icons * fix test failures * handle exception in export plugin --------- Co-authored-by: Jennifer Kotler <[email protected]>
* remove call to reset limits during unit conversion * custom logic for mapping y-limits on unit change * remove delay_callback --------- Co-authored-by: gibsongreen <[email protected]>
* logic to connect visibilities of child/parent layers from data-menu * test coverage
spacetelescope#3369) * expose zoom_to_selected in catalogs plugin api * kyle comments
* switch order of setting ymin and ymax * change log * . * remove test because it requires image to be rendered
…up-to-date n render
…ionality for flux %ile removal
james-trayford
force-pushed
the
sonify-plugin-updates-jtedits
branch
from
49520a8 to
1c74635
Compare
* TST: Add Linux job to use Python 3.13 Ignore DeprecationWarning from ipykernel. * TST: Use Python 3.13 on devdeps
* adding check for subset name * Create list of reserved labels at app level to check against * Force labels to strings now so don't need None * Move validation function, minimize layer reprocessing, start adding to subset_tools * Warn if label is not alphanumberic, adding code from spacetelescope#1291 Co-authored-by: Kyle Conroy <[email protected]> * Add SubsetRenameMessage * Update all SubsetSelects in plugins when subset is renamed. * allow plugin components to call `send_state` not needed anywhere yet * Working on updating subset items in LayerSelect on rename, buggy right now * Add passing test, refactor app.get_subsets for better efficiency in single subset case * Add changelog * Remove leftover lower() from rebase * Fix tests * Remove debugging prints * Add docstrings, remove kwarg that isn't relevant to users * Don't allow renaming to Subset N * Raise instead of error, add test * Remove debugging prints * Raise error if trying to rename a subset that doesn't exist * Remove prints * codesty.e * Don't check for hardcoded 'Subset' in label * Fix failing test * Fix check to be more general * Move changelog entry * Restore updated subset to layer select menus with icon * Don't duplicate renamed subset in export plugin * Update extracted spectrum data collection item as well Update extracted spectrum data collection item as well * Update old data menu items * Address review comments * Codestyle * Check old label * Add simple test * Test rename_selected * Codestyle * Cover another case * Add methods to class docstring --------- Co-authored-by: Clare Shanahan <[email protected]> Co-authored-by: Kyle Conroy <[email protected]>
* BUG: Also check for inf in spaxel tool when setting new Y limits * Add change log * BUG: Avoid INF in MANGA IVAR uncert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address some of the listener to-do list
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.flux_viewer.update_listener_wlsnow takes a sequence of bounds rather than a min and max, to allow for composite selections with appropriate@observekeyword for spectral subselection.vuefile.TrueChecklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.