Add _very initial_ support for 3.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least for bwpresets from 3.0 Alpha 1 and Beta 1 branches, those saved for The Grid Device have a different header structure. The first tweak is that the four bytes after BtWg are "0002" and not "0001" (in character form) The second is that the header "section" is 60 bytes long instead of 40 This is a _very quick_ tweak to allow parsing of these Presets without failing. There's plenty more to be done to support these newer headers and perhaps any features that come with them. Before the metadata is decoded, I made it check the 8th character, and if it's "2" (the newer value) then it will re-read the header as 60 bytes. The rest continues as usual and there's no errors when parsing the metadata. Of the bwpresets I've found, I could still parse the contents of one of them but most would still fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for bwpresets from 3.0 Alpha 1 and Beta 1 branches, those saved for The Grid Device have a different header structure.
The first tweak is that the four bytes after BtWg are "0002" and not "0001" (in character form)
The second is that the header "section" is 60 bytes long instead of 40
This is a very quick tweak to allow parsing of these Presets without failing. There's plenty more to be done to support these newer headers and perhaps any features that come with them.
Before the metadata is decoded, I made it check the 8th character, and if it's "2" (the newer value) then it will re-read the header as 60 bytes.
The rest continues as usual and there's no errors when parsing the metadata. Of the bwpresets I've found, I could still parse the contents of one of them but most would still fail