Skip to content

Commit

Permalink
Add references to github issue (apache#11784)
Browse files Browse the repository at this point in the history
  • Loading branch information
findepi authored Aug 2, 2024
1 parent 0332eb5 commit b89037f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions datafusion/core/src/datasource/listing/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ impl TableProvider for ListingTable {
filters: &[Expr],
limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>> {
// TODO remove downcast_ref from here?
// TODO (https://github.com/apache/datafusion/issues/11600) remove downcast_ref from here?
let session_state = state.as_any().downcast_ref::<SessionState>().unwrap();
let (mut partitioned_file_lists, statistics) = self
.list_files_for_scan(session_state, filters, limit)
Expand Down Expand Up @@ -883,7 +883,7 @@ impl TableProvider for ListingTable {
// Get the object store for the table path.
let store = state.runtime_env().object_store(table_path)?;

// TODO remove downcast_ref from here?
// TODO (https://github.com/apache/datafusion/issues/11600) remove downcast_ref from here?
let session_state = state.as_any().downcast_ref::<SessionState>().unwrap();
let file_list_stream = pruned_partition_list(
session_state,
Expand Down
2 changes: 1 addition & 1 deletion datafusion/core/src/datasource/listing_table_factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ impl TableProviderFactory for ListingTableFactory {
state: &dyn Session,
cmd: &CreateExternalTable,
) -> Result<Arc<dyn TableProvider>> {
// TODO remove downcast_ref from here. Should file format factory be an extension to session state?
// TODO (https://github.com/apache/datafusion/issues/11600) remove downcast_ref from here. Should file format factory be an extension to session state?
let session_state = state.as_any().downcast_ref::<SessionState>().unwrap();
let file_format = session_state
.get_file_format_factory(cmd.file_type.as_str())
Expand Down

0 comments on commit b89037f

Please sign in to comment.