-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent FORMS_URLFIELD_ASSUME_HTTPS warning on Django 5.0 #384
Prevent FORMS_URLFIELD_ASSUME_HTTPS warning on Django 5.0 #384
Conversation
3cc5e8f
to
fe4903c
Compare
Tests are passing but Codecov is failing to upload:
I think this needs an admin to reinstall the app or grab a token from codecov.io. Or we could ditch codecov per https://hynek.me/articles/ditch-codecov-python/ - that’s what I did for my open source projects. |
Thanks @adamchainz I opened an issue about that #390 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pauloxnet - do you have permissions to rebase this PR so it reruns the tests now that the codecov issue is resolved? |
@pauloxnet - can you also confirm if you have been given full maintainer permissions on this project yet please |
@uhurusurfa please avoid tagging me 2 times in 1 minute in 2 separate comments, as I already wrote I don't have full maintainer permission and I can't access the settings or force a rebase. In future when you tag me in an issue please wait for a response, I'll try to reply when I'll find the free time to do that, it can be days, I understand your enthusiasm, but this is a total volunteer and unpaid job for me, and I can't assure any time of response or unlimited amount of time in it. In the alternative, tag other maintainers, or apply to be part of the project. |
Fair enough. I will try alternative roputes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
fe4903c
to
b8e94fd
Compare
Rebased. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 25 25
Lines 1197 1197
Branches 86 86
=======================================
Hits 1082 1082
Misses 88 88
Partials 27 27 ☔ View full report in Codecov by Sentry. |
Prevent this warning:
The approach of listing the setting in
deprecated_settings
is the same as forSTORAGES
in #349, but it does not need to be conditional.