Upgrade to latest chdkptp and update chdkptp_module.diff to build libraries #10
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries nicely. Since they have special properties like the PTP traceback.
First, chdkptp errors do not have a 'message' key, instead, it is 'msg'. Then, for some reason the dictionary get() method throws an error: TypeError: 'NoneType' object is not callable no matter if the key exists, or not. Not sure why that is so.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self explanatory. See the commit comments for details. The upgrade to latest chdkptp is straightforward, just some things moved around in the files modified by chdkptp_modue.diff so that is reflected there.
Then the libraries needed to be built in os x, etc. as reflected in this issue, so this pull request should close that: #8