nomerge: guessing what msvc could complain about

jbeder · Jul 30, 2024 · f40095f · f40095f
1 parent acf2e70
commit f40095f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/include/yaml-cpp/fptostring.h b/include/yaml-cpp/fptostring.h
@@ -10,9 +10,13 @@
 
 namespace YAML {
 // "precision = 0" refers to shortest known unique representation of the value
-YAML_CPP_API std::string FpToString(float v, size_t precision = 0);
-YAML_CPP_API std::string FpToString(double v, size_t precision = 0);
-YAML_CPP_API std::string FpToString(long double v, size_t precision = 0);
+YAML_CPP_API std::string FpToString(float v, size_t precision );
+YAML_CPP_API std::string FpToString(double v, size_t precision);
+YAML_CPP_API std::string FpToString(long double v, size_t precision);
+YAML_CPP_API std::string FpToString(float v);
+YAML_CPP_API std::string FpToString(double v);
+YAML_CPP_API std::string FpToString(long double v);
+
 }
 
 #endif
diff --git a/src/fptostring.cpp b/src/fptostring.cpp
@@ -204,4 +204,14 @@ std::string FpToString(long double v, size_t precision) {
   return ss.str();
 }
 
+std::string FpToString(float v) {
+    return FpToString(v, 0);
+}
+std::string FpToString(double v) {
+    return FpToString(v, 0);
+}
+std::string FpToString(long double v) {
+    return FpToString(v, 0);
+}
+
 }
diff --git a/test/fptostring_test.cpp b/test/fptostring_test.cpp
@@ -1,14 +1,16 @@
 #include "yaml-cpp/fptostring.h"
 #include "gtest/gtest.h"
 
-namespace YAML {
+
+using YAML::FpToString;
+
 namespace {
 
 /**
  * Helper function, that converts double to string as std::stringstream would do
  */
 template <typename T>
-static std::string convert_with_stringstream(T v, size_t precision = 0) {
+std::string convert_with_stringstream(T v, size_t precision = 0) {
   std::stringstream ss;
   if (precision > 0) {
     ss << std::setprecision(precision);
@@ -239,4 +241,3 @@ TEST(FpToStringTest, conversion_float) {
 }
 
 }  // namespace
-}  // namespace YAML