Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set surefire runOrder to alphabetical for microprofile-health #326

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jan 28, 2025

Here we're setting the property to alphabetical for both the regulare and bootable execution of the maven-surefire-plugin.

Resolves #325

Internal validation runs, specifically the Oracle JDKs related combos:

  1. Regular execution:
  • job: eap-8.x-microprofile-testsuite
  • run: 1221 1222 & 1223
  1. Bootable JAR execution
  • job: eap-8.x-microprofile-testsuite-bootable
  • run: 664 665 & 666

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Link Reference to the passing job is provided
  • Code is self-descriptive and/or documented
  • N/A Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

@fabiobrz fabiobrz requested a review from marekkopecky January 28, 2025 14:01
@fabiobrz fabiobrz marked this pull request as ready for review January 28, 2025 14:01
@fabiobrz fabiobrz closed this Jan 28, 2025
@fabiobrz fabiobrz reopened this Jan 28, 2025
@marekkopecky
Copy link
Contributor

Thank you for this PR! I added just one minor comment.

@fabiobrz
Copy link
Member Author

Thank you for this PR! I added just one minor comment.

Thanks @marekkopecky - BTW the failures are not related to the changes here, which confirm the workaround actually works to address the precondition described in #325

@fabiobrz fabiobrz force-pushed the health.def-proc-fix branch from 82ea9ac to e819ed8 Compare January 29, 2025 12:55
@fabiobrz fabiobrz force-pushed the health.def-proc-fix branch from e819ed8 to b823bf1 Compare January 29, 2025 13:51
Copy link
Contributor

@marekkopecky marekkopecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, PR LGTM.

@marekkopecky marekkopecky merged commit 038cb9c into jboss-eap-qe:master Jan 30, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workaround the condition that makes DefaultReadinessProcedureHealthTest fail on Oracle JDKs
2 participants