MP Health test development #87

istraka · 2019-12-11T13:37:18Z

refactoring
negative scenario for MIME types
multiple deployment / deployment with subdeployments scenario
new health version test
JavaDoc

https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/eap-7.x-microprofile-simple-face/11/

Please make sure your PR meets the following requirements:

Pull Request contains description for the changes
Pull Request does not include fixes for multiple issues / topics
Code is formatted, imports ordered, code compiles and tests are passing
Link to passing job is provided
Code is self-descriptive and/or documented
Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

istraka · 2019-12-11T13:47:41Z

Jenkins is down for now. Here is a distribution (available only from RedHat network) http://download.eng.brq.redhat.com/scratch/istraka/wildfly-mp-ft-health.zip.

The distribution is a merge of wildfly/wildfly#12800 and wildfly/wildfly#12720

fabiobrz

Hi @istraka, thanks for your work.
I've left some minor comments and a broader consideration regarding multi deployment scenarios (see MultiAppHealthTest and subclasses).

microprofile-health/pom.xml

fabiobrz · 2019-12-11T16:17:12Z

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthNullTest.java


    @ContainerResource
    ManagementClient managementClient;

    @Deployment(testable = false)
    public static Archive<?> deployment() {
-        WebArchive war = ShrinkWrap.create(WebArchive.class, "MicroProfileHealthNullTest.war")
+        WebArchive war = ShrinkWrap.create(WebArchive.class, HealthTest.class.getSimpleName() + ".war")


Maybe you meant HealthTest.class.getSimpleName() -> HealthNullTest.class.getSimpleName()?

Yes, thanks!

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthTest.java

fabiobrz · 2019-12-11T16:31:46Z

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/MultiAppHealthTest.java

+                .contentType(ContentType.JSON)
+                .header("Content-Type", containsString("application/json"))
+                .body("status", is("UP"),
+                        "checks", hasSize(3), // BothHealthCheck contains both annotations: @Liveness and @Readiness


Looks like BothHealthCheck is not deployed by any of the two classes extending this one (maybe you meant SimplifiedHealthTest which as well has both annotations.
Anyway, generally speaking, I am concerned about putting this kind of logic into this abstract superclass, while the control over what is deployed is in concrete subclass(es). In fact a comment had to be added to track this.
WDYT?

Yes, I see your point. The abstract class tests expect sub-classes to deploy something specific / limited. What about having a sort of TestDelegation class instead of this abstract class?

The abstract class tests expect sub-classes to deploy something specific / limited.

Correct. The key point of my consideration is to not scatter implementation logic over hierarchy.
Any "pattern" that would solve this is good IMO. Delegation to run some supplied code would work, I guess, but then what's the point for that "empty" superclass?
I - for instance - would start from removing the "details-aware" code from the superclass to subclasses - i.e. I'd move the checks down, but that would just be my immediate coding attempt.
Then the design could be adjusted further, somebody else could choose composition.
I'd say there are several solutions and you know better the detail.

Yeah, I would get rid of the hierarchy....Fixing...

fabiobrz · 2019-12-11T16:38:13Z

pom.xml

+            </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-io</artifactId>


What is this dependency used for?

Tests brought by next iteration will use it.

Ok, thanks.

Tests brought by next iteration will use it.

please don't add it here, viz "Pull Request does not include fixes for multiple issues / topics" checkbox

fabiobrz · 2019-12-11T16:42:33Z

pom.xml

@@ -132,6 +143,9 @@
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.22.2</version>
                <configuration>
+                    <environmentVariables>
+                        <JBOSS_HOME>${jboss.home}</JBOSS_HOME>
+                    </environmentVariables>


Why is this environment variable needed to be passed to surefire now?

Because of Creaper. Not used now, but in following PR it will be needed.

Can you add a short explanation for this? I think it is needed for it to be shared here. Thanks.

I can not execute CLI command using Creaper

ERROR: Setup failed during setup. Offending class 'org.jboss.eap.qe.microprofile.health.integration.FailSafeCDICustomConfigSourceHealthTest$SetupTask@381d7219' org.wildfly.extras.creaper.core.CommandFailedException: org.wildfly.extras.creaper.core.online.CliException: org.jboss.as.cli.CommandLineException: java.util.concurrent.ExecutionException: org.jboss.as.cli.CommandLineException: JBOSS_HOME environment variable is not set. at org.wildfly.extras.creaper.core.online.AutomaticErrorHandlingForCommands.commandFailedWithCause(AutomaticErrorHandlingForCommands.java:142) at org.wildfly.extras.creaper.core.online.AutomaticErrorHandlingForCommands.executeCli(AutomaticErrorHandlingForCommands.java:109) at org.wildfly.extras.creaper.commands.modules.AddModule.apply(AddModule.java:91) at org.wildfly.extras.creaper.core.online.OnlineManagementClientImpl.apply(OnlineManagementClientImpl.java:136) at org.wildfly.extras.creaper.core.online.OnlineManagementClientImpl.apply(OnlineManagementClientImpl.java:125) at org.wildfly.extras.creaper.core.online.LazyOnlineManagementClient.apply(LazyOnlineManagementClient.java:50) at org.jboss.eap.qe.microprofile.health.integration.ModuleUtil.setupModule(ModuleUtil.java:21) at org.jboss.eap.qe.microprofile.health.integration.FailSafeCDICustomConfigSourceHealthTest$SetupTask.setup(FailSafeCDICustomConfigSourceHealthTest.java:71) at org.jboss.as.arquillian.container.ServerSetupObserver$ServerSetupTaskHolder.setup(ServerSetupObserver.java:185) at org.jboss.as.arquillian.container.ServerSetupObserver.handleBeforeDeployment(ServerSetupObserver.java:108) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105) at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:147) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:118) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.executeOperation(ContainerDeployController.java:239) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deploy(ContainerDeployController.java:118) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90) at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createDeploymentContext(ContainerDeploymentContextHandler.java:71) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95) at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createContainerContext(ContainerDeploymentContextHandler.java:54) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95) at org.jboss.arquillian.container.impl.client.container.DeploymentExceptionHandler.verifyExpectedExceptionDuringDeploy(DeploymentExceptionHandler.java:47) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105) at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:92) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:77) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachDeployment(ContainerDeployController.java:232) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachManagedDeployment(ContainerDeployController.java:212) at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deployManaged(ContainerDeployController.java:77) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105) at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62) at org.jboss.arquillian.container.test.impl.client.ContainerEventController.execute(ContainerEventController.java:96) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90) at org.jboss.arquillian.test.impl.TestContextHandler.createClassContext(TestContextHandler.java:83) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95) at org.jboss.arquillian.test.impl.TestContextHandler.createSuiteContext(TestContextHandler.java:69) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86) at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133) at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105) at org.jboss.arquillian.test.impl.EventTestRunnerAdaptor.beforeClass(EventTestRunnerAdaptor.java:89) at org.jboss.arquillian.junit.Arquillian$2.evaluate(Arquillian.java:163) at org.jboss.arquillian.junit.Arquillian.multiExecute(Arquillian.java:350) at org.jboss.arquillian.junit.Arquillian.access$200(Arquillian.java:54) at org.jboss.arquillian.junit.Arquillian$3.evaluate(Arquillian.java:177) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:115) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) Caused by: org.wildfly.extras.creaper.core.online.CliException: org.jboss.as.cli.CommandLineException: java.util.concurrent.ExecutionException: org.jboss.as.cli.CommandLineException: JBOSS_HOME environment variable is not set. at org.wildfly.extras.creaper.core.online.OnlineManagementClientImpl.executeCli(OnlineManagementClientImpl.java:210) at org.wildfly.extras.creaper.core.online.AutomaticErrorHandlingForCommands.executeCli(AutomaticErrorHandlingForCommands.java:107) ... 107 more Caused by: org.jboss.as.cli.CommandLineException: java.util.concurrent.ExecutionException: org.jboss.as.cli.CommandLineException: JBOSS_HOME environment variable is not set. at org.jboss.as.cli.impl.CommandContextImpl.execute(CommandContextImpl.java:878) at org.jboss.as.cli.impl.CommandContextImpl.handleLegacyCommand(CommandContextImpl.java:1840) at org.jboss.as.cli.impl.CommandContextImpl.handle(CommandContextImpl.java:815) at org.jboss.as.cli.impl.WorkaroundForWFCORE526_CommandContextImpl.handle(WorkaroundForWFCORE526_CommandContextImpl.java:14) at org.wildfly.extras.creaper.core.online.OnlineManagementClientImpl.executeCli(OnlineManagementClientImpl.java:203) ... 108 more Caused by: java.util.concurrent.ExecutionException: org.jboss.as.cli.CommandLineException: JBOSS_HOME environment variable is not set. at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191) at org.jboss.as.cli.impl.CommandExecutor.execute(CommandExecutor.java:713) at org.jboss.as.cli.impl.CommandExecutor.execute(CommandExecutor.java:694) at org.jboss.as.cli.impl.CommandContextImpl.lambda$handleLegacyCommand$4(CommandContextImpl.java:1841) at org.jboss.as.cli.impl.CommandContextImpl.execute(CommandContextImpl.java:865) ... 112 more Caused by: org.jboss.as.cli.CommandLineException: JBOSS_HOME environment variable is not set. at org.jboss.as.cli.handlers.module.ASModuleHandler.getModulesDir(ASModuleHandler.java:570) at org.jboss.as.cli.handlers.module.ASModuleHandler.addModule(ASModuleHandler.java:395) at org.jboss.as.cli.handlers.module.ASModuleHandler.doHandle(ASModuleHandler.java:346) at org.jboss.as.cli.handlers.CommandHandlerWithHelp.handle(CommandHandlerWithHelp.java:89) at org.jboss.as.cli.impl.CommandExecutor$2.lambda$build$0(CommandExecutor.java:685) at org.jboss.as.cli.impl.CommandExecutor.lambda$execute$0(CommandExecutor.java:708) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:832)

Thanks, not really "short" but definitely valuable :)

fabiobrz · 2019-12-11T16:45:25Z

pom.xml

@@ -122,6 +123,16 @@
                <version>${project.version}</version>
                <scope>test</scope>
            </dependency>
+            <dependency>
+                <groupId>org.wildfly.extras.creaper</groupId>
+                <artifactId>creaper-commands</artifactId>


See previous comment about creaper-commands

Next iteration.

OK thanks, same as above.

fabiobrz · 2019-12-11T17:07:05Z

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SimplifiedHealthTest.java

+                .contentType(ContentType.JSON)
+                .header("Content-Type", containsString("application/json"))
+                .body("status", is("UP"),
+                        "checks", hasSize(2), // BothHealthCheck contains both annotations: @Liveness and @Readiness


BothHealthCheck -> SimplifiedHealthTest here?

fabiobrz · 2019-12-11T17:20:50Z

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthTest.java

    }

+    /**
+     * @tpTestDetails Customer scenario where health check contains customer data.


health check -> liveness check?

fabiobrz · 2019-12-11T17:21:32Z

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthTest.java

@@ -74,6 +83,11 @@ public void testLivenessEndpoint() {
                        "checks.data[0..1].key", hasItems("value"));
    }

+    /**
+     * @tpTestDetails Customer scenario where health check contains customer data.


health check -> readiness check?

istraka · 2019-12-12T09:22:14Z

@fabiobrz I have addressed issues. At the end I haven't implemented any sort of test delegation class since it is too complicated for the purpose. I just get rid of the hierarchy. Let me know if you are fine with changes so I would squash commits.

fabiobrz

Hi @istraka, thanks for addressing my comments. See my request for documenting right here in the PR what's the future usage for environment variable passed to surefire. Then there are just some minor fixes. Maybe, if Jenkin's now up, we could have a run linked, here.

microprofile-health/pom.xml

fabiobrz · 2019-12-12T10:12:11Z

pom.xml

@@ -122,6 +123,16 @@
                <version>${project.version}</version>
                <scope>test</scope>
            </dependency>
+            <dependency>
+                <groupId>org.wildfly.extras.creaper</groupId>
+                <artifactId>creaper-commands</artifactId>


OK thanks, same as above.

fabiobrz · 2019-12-12T10:12:40Z

pom.xml

+            </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-io</artifactId>


Ok, thanks.

fabiobrz · 2019-12-12T10:13:33Z

pom.xml

@@ -132,6 +143,9 @@
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.22.2</version>
                <configuration>
+                    <environmentVariables>
+                        <JBOSS_HOME>${jboss.home}</JBOSS_HOME>
+                    </environmentVariables>


Can you add a short explanation for this? I think it is needed for it to be shared here. Thanks.

fabiobrz · 2019-12-12T10:17:04Z

...ile-health/src/test/java/org/jboss/eap/qe/microprofile/health/MultiDeploymentHealthTest.java

+                .contentType(ContentType.JSON)
+                .header("Content-Type", containsString("application/json"))
+                .body("status", is("UP"),
+                        "checks", hasSize(3), // BothHealthCheck contains both annotations: @Liveness and @Readiness


Here again I think it's BothHealthCheck -> SimplifiedHealthCheck or just remove the comment.

fabiobrz · 2019-12-12T10:20:27Z

...ofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SubdeploymentHealthTest.java

+                .contentType(ContentType.JSON)
+                .header("Content-Type", containsString("application/json"))
+                .body("status", is("UP"),
+                        "checks", hasSize(3), // BothHealthCheck contains both annotations: @Liveness and @Readiness


BothHealthCheck -> SimplifiedHealthCheck or just remove the comment.

istraka · 2019-12-12T13:18:55Z

Comments were removed.

fabiobrz

Hi @istraka, LGTM, approving.

fabiobrz · 2019-12-12T14:41:13Z

pom.xml

@@ -132,6 +143,9 @@
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.22.2</version>
                <configuration>
+                    <environmentVariables>
+                        <JBOSS_HOME>${jboss.home}</JBOSS_HOME>
+                    </environmentVariables>


Thanks, not really "short" but definitely valuable :)

rsvoboda · 2019-12-12T15:01:35Z

@istraka rebase please

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthNullTest.java

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SimplifiedHealthTest.java

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthNullTest.java

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/MimeTypeHealthTest.java

...ile-health/src/test/java/org/jboss/eap/qe/microprofile/health/MultiDeploymentHealthTest.java

mnovak · 2019-12-12T16:03:37Z

@istraka I would like to see improved JavaDoc with test description so it's clear what the test is checking. Most of the javadoc is too general.

istraka · 2019-12-12T17:32:21Z

@mnovak1 I have addressed issues. Please review.

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthDeprecatedTest.java

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthUtil.java

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SimplifiedHealthTest.java

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthDeprecatedTest.java

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthUrlProvider.java

mnovak

Almost LGTM.

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SimplifiedHealthTest.java

...ofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/tools/HealthUrlProvider.java

refactoring negative scenario for MIME types multiple deployment / deployment with subdeployments scenario new health version test JavaDoc

istraka · 2020-01-02T07:51:12Z

Fixes #14

istraka force-pushed the mp-health branch from 2d8d489 to 2bba6c0 Compare December 11, 2019 13:44

istraka force-pushed the mp-health branch from 2bba6c0 to 894f329 Compare December 11, 2019 15:33

fabiobrz requested changes Dec 11, 2019

View reviewed changes

fabiobrz requested changes Dec 12, 2019

View reviewed changes

istraka force-pushed the mp-health branch from c35d2b7 to c4f4f02 Compare December 12, 2019 13:29

fabiobrz approved these changes Dec 12, 2019

View reviewed changes

mnovak requested changes Dec 12, 2019

View reviewed changes

istraka force-pushed the mp-health branch 2 times, most recently from 64b082e to f5d61ab Compare December 12, 2019 17:30

mnovak requested changes Dec 13, 2019

View reviewed changes

istraka force-pushed the mp-health branch 2 times, most recently from 40c3ca4 to 713b20f Compare December 13, 2019 10:00

mnovak reviewed Dec 13, 2019

View reviewed changes

microprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/HealthUrlProvider.java Outdated Show resolved Hide resolved

istraka force-pushed the mp-health branch from 713b20f to 7f2b47a Compare December 13, 2019 11:18

mnovak reviewed Dec 13, 2019

View reviewed changes

...oprofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/SimplifiedHealthTest.java Outdated Show resolved Hide resolved

...ofile-health/src/test/java/org/jboss/eap/qe/microprofile/health/tools/HealthUrlProvider.java Show resolved Hide resolved

istraka force-pushed the mp-health branch from 7f2b47a to 3a11ae5 Compare December 13, 2019 11:38

MP Health test development

4f95c4a

refactoring negative scenario for MIME types multiple deployment / deployment with subdeployments scenario new health version test JavaDoc

istraka force-pushed the mp-health branch from 3a11ae5 to 4f95c4a Compare December 13, 2019 11:39

mnovak self-requested a review December 13, 2019 13:11

mnovak approved these changes Dec 13, 2019

View reviewed changes

mnovak merged commit 86fac04 into jboss-eap-qe:master Dec 13, 2019

fabiobrz mentioned this pull request Dec 17, 2019

Project ownership / roles #72

Closed

MP Health test development #87

MP Health test development #87

Conversation

istraka commented Dec 11, 2019 • edited Loading

istraka commented Dec 11, 2019

fabiobrz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabiobrz Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

istraka commented Dec 12, 2019 • edited Loading

fabiobrz left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

istraka commented Dec 12, 2019

fabiobrz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsvoboda commented Dec 12, 2019

mnovak commented Dec 12, 2019

istraka commented Dec 12, 2019

mnovak left a comment

Choose a reason for hiding this comment

istraka commented Jan 2, 2020 • edited Loading

istraka commented Dec 11, 2019 •

edited

Loading

fabiobrz Dec 11, 2019 •

edited

Loading

istraka commented Dec 12, 2019 •

edited

Loading

fabiobrz left a comment •

edited

Loading

istraka commented Jan 2, 2020 •

edited

Loading