Fix wrong line numbers in some cases #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add description? |
|
I added a description |
|
Thanks. But does this patch really fix this?
I don't think |
|
Before this patch map was lineNum -> pc, now is pc -> lineNum (swap key & value), so for one pc can be only one lineNumber |
I understood this. If so, can you revise the description (and title?) of this pull req? Furthermore, does the test case check this problem? |
kuznet1
changed the title
|
Yes, of course. Without fix it reports that exception is thrown from 4th line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic allowed to make multiple entries in line number table for one pc. Usually it works fine as in most cases hashmap iterate by increasing key and only the last entry in line number table for each PC is taken into account. But when one line is <16, and second line is >= 16 (default hashmap capacity) then it will iterated in reverse order, so jvm reports wrong line and test fails. I swapped key & value of map in LineNumberAttributeBuilder, so for one pc can match only one lineNumber.