Quarkus update to 3.17.x #470
Conversation
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/399/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
3417984 to
32b10d5
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/404/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
32b10d5 to
891c781
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/405/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/406/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/407/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
199ae0d to
a6da768
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/410/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/411/ |
pom.xml
Outdated
| @@ -147,8 +147,8 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
| <!-- quarkus --> | |||
| <quarkus-plugin.version>3.4.2</quarkus-plugin.version> | |||
| <quarkus.platform.version>3.4.2</quarkus.platform.version> | |||
| <quarkus-plugin.version>3.16.0</quarkus-plugin.version> | |||
There was a problem hiding this comment.
If a large jump like this is causing difficulty, how about trying a slightly lower jump to 3.8 LTS (https://quarkus.io/security/)
There was a problem hiding this comment.
Good idea Tom! I created the PR here: #477
Please consider that for 3.9 or higher the artifact names' change is needed too, see https://quarkus.io/guides/rest-migration
There was a problem hiding this comment.
Glad you liked the idea - I have approved and merged it!
marcosgopen
force-pushed
the
quarkus-update
branch
from
3b87118 to
eae9899
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/426/ |
|
Quickstart rebase on main failed: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/429/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
eae9899 to
1d38438
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/430/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
1d38438 to
e176112
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/431/ |
marcosgopen
force-pushed
the
quarkus-update
branch
from
e176112 to
7541ebc
Compare
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/432/ |
|
Thank you Marco, I would just like to ask if you might like to keep the Hold label on until you have created the issue you refer to here: "Before merging this I would like to open an issue to investigate more how to migrate servlets and use quarkus reasteasy reactive with LRA."? On the other hand, I am not sure why that should need to be a pre-requisite and I would personally be happy to approve this with a view to it being merged before an issue is created. |
I think you are right and the task was no dependent on this PR to be approved. BTW I created the issue: https://issues.redhat.com/browse/JBTM-3969 |
It's a non-trivial change, most likely a lot harder than even supporting "reactive JTA". |
Update quarkus to 3.17.5
Since Quarkus 3.9.x Quarkus rest default is resteasy reactive (see https://quarkus.io/guides/rest-migration).
Since Narayana LRA is a servlet-based JAX-RS it is not possible to move now to Quarkus resteasy reactive, which is the default choice, is not feasible at the moment (see https://quarkus.io/guides/rest-migration#servlets). So we need to stick with reasteasy classic for the moment.
cc @mmusgrov @tomjenkinson