Skip to content

Commit

Permalink
Improve Appraisal config
Browse files Browse the repository at this point in the history
  • Loading branch information
n-rodriguez committed Nov 7, 2024
1 parent 12d8198 commit eff8410
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
- '3.1'
- 'head'
rails:
- rails_7.2.0
- rails_7.1.3
- rails_7.0.8
- rails_7.2
- rails_7.1
- rails_7.0

env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.rails }}.gemfile
Expand Down
12 changes: 6 additions & 6 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

appraise 'rails_7.0.8' do
gem 'rails', '7.0.8'
appraise 'rails_7.0' do
gem 'rails', '~> 7.0.0'

# Fix: LoadError: cannot load such file -- base64
install_if '-> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.3.0") }' do
Expand All @@ -13,8 +13,8 @@ appraise 'rails_7.0.8' do
end
end

appraise 'rails_7.1.3' do
gem 'rails', '7.1.3'
appraise 'rails_7.1' do
gem 'rails', '~> 7.1.0'

# Fix:
# warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0.
Expand All @@ -24,6 +24,6 @@ appraise 'rails_7.1.3' do
end
end

appraise 'rails_7.2.0' do
gem 'rails', '7.2.0'
appraise 'rails_7.2' do
gem 'rails', '~> 7.2.0'
end
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ gem "rubocop-rspec"
gem "rubocop-rspec_rails"
gem "simplecov"
gem "sqlite3", "~> 1.5.0"
gem "rails", "7.0.8"
gem "rails", "~> 7.0.0"

install_if -> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.3.0") } do
gem "base64"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ gem "rubocop-rspec"
gem "rubocop-rspec_rails"
gem "simplecov"
gem "sqlite3", "~> 1.5.0"
gem "rails", "7.1.3"
gem "rails", "~> 7.1.0"

install_if -> { Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0") } do
gem "logger"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ gem "rubocop-rspec"
gem "rubocop-rspec_rails"
gem "simplecov"
gem "sqlite3", "~> 1.5.0"
gem "rails", "7.2.0"
gem "rails", "~> 7.2.0"

gemspec path: "../"

0 comments on commit eff8410

Please sign in to comment.