Use API to get_user_str_from_profile #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbsparrow is working on a fix based on the 5.7.2 tag |
lerroynick
reviewed
Nov 27, 2024
| @@ -217,10 +217,12 @@ async def get_user_str_from_post(self, scrape_item: ScrapeItem) -> str: | |||
| return soup.select_one("a[class=post__user-name]").text | |||
|
|
|||
| async def get_user_str_from_profile(self, scrape_item: ScrapeItem) -> str: | |||
| """Gets the user string from a scrape item.""" | |||
| """Gets the user string from a scrape item""" | |||
| service, user = await self.get_service_and_user(scrape_item) | |||
There was a problem hiding this comment.
remove await. await cant return tuples, and get_service_and_user is has not anything asyncable anyway :)
Then it works.
|
#326 Fixes this & Kemono. Took a bit long I got distracted 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #320