Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pydantic config settings fixes #340

Merged
merged 23 commits into from
Dec 5, 2024

Conversation

NTFSvolume
Copy link
Collaborator

  1. Rewrite config file if one of the keys was missing (new logic)
  2. Fix AppriseURL model rejecting empty tags
  3. Add missing setting aliases
  4. Validate all configs when running with --config ALL
  5. Other minor fixes

@NTFSvolume NTFSvolume added the bug Something isn't working label Nov 29, 2024
@NTFSvolume NTFSvolume marked this pull request as draft November 30, 2024 07:54
@NTFSvolume
Copy link
Collaborator Author

Added some pre-validators to automatically handle common invalid values and smooth the transition a bit

@NTFSvolume NTFSvolume marked this pull request as ready for review November 30, 2024 08:34
@NTFSvolume NTFSvolume marked this pull request as draft November 30, 2024 10:35
@NTFSvolume NTFSvolume marked this pull request as ready for review November 30, 2024 11:19
@NTFSvolume NTFSvolume marked this pull request as draft December 1, 2024 23:58
@datawhores
Copy link
Collaborator

datawhores commented Dec 2, 2024

I tested this out
So far everything seems to be working

There is a small validation error with browser sites, but that might be from the current master
The merge conflict was minor

@NTFSvolume NTFSvolume marked this pull request as ready for review December 2, 2024 02:13
@NTFSvolume NTFSvolume marked this pull request as draft December 2, 2024 02:26
@NTFSvolume NTFSvolume marked this pull request as ready for review December 2, 2024 02:28
@NTFSvolume
Copy link
Collaborator Author

Updates

  1. Add timedelta and date yaml representer
  2. Rename all log filename options cause now they are not filenames, they are paths. The old config settings and CLI argumets still work but they are now in the deprecated group
  3. Add additional pre-validators and fix URLs pre-validators
  4. Replace Forums and Websites enums with regular strings. Enums were giving warnings by pydantic because their names and their values were different.

This PR has many commits but they do not have significant value on their own. Please squash before merging.

@NTFSvolume NTFSvolume merged commit 74d14ed into jbsparrow:master Dec 5, 2024
3 checks passed
@NTFSvolume NTFSvolume deleted the pydantic_fixes branch December 5, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants