Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log errors on startup #412

Merged
merged 9 commits into from
Dec 30, 2024

Conversation

NTFSvolume
Copy link
Collaborator

  • Add a basic startup logger to log any errors that may occur at startup (YAML errors, validation errors, database errors, manager errors, or any unknown errors). This log file will always be in the current working directory, as there is a possibility that the manager has not been set up yet.
  • Handle all possible cases of an invalid YAML file
  • Related to [BUG] 'sqlite3.OperationalError: no such table: hash' error when starting #409

- Add a basic startup logger to log any errors that occur during startup (YAML errors, validation errors, database errors, or any unknown errors). This log file will always be in the current working directory, as there is a possibility that the manager has not been set up yet.
- Handle all posible cases of an invalid yaml file
@NTFSvolume NTFSvolume added bug Something isn't working refactor No user facing changes labels Dec 28, 2024
@NTFSvolume NTFSvolume requested a review from jbsparrow December 28, 2024 02:00
cyberdrop_dl/utils/yaml.py Outdated Show resolved Hide resolved
@NTFSvolume NTFSvolume requested a review from jbsparrow December 28, 2024 19:45
@NTFSvolume NTFSvolume marked this pull request as draft December 30, 2024 01:42
@NTFSvolume NTFSvolume marked this pull request as ready for review December 30, 2024 03:04
@NTFSvolume NTFSvolume merged commit ac402a7 into jbsparrow:master Dec 30, 2024
5 checks passed
@NTFSvolume NTFSvolume deleted the handle_startup_error branch December 30, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor No user facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants