ci/cd: update workflows, ruff rules and pre-commit hooks #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General propose: - `check-merge-conflict` - `name-tests-test` - `check-illegal-windows-names` These are for the release scripts: - `check-executables-have-shebangs` - `check-shebang-scripts-are-executable` - `check-added-large-files` - `check-case-conflict`
New rules: - `ASYNC` # async calls that do not await anything or use blocking methods - `FA100` # future annotations - `PTH` # use pathlib instead of os - `T20` # flake8-print - `TID` # flake8-tidy-imports Change rules - Replace `TCH` with `TC` (new name for type checking imports) and add it as a safe fix - Marked `ERA` (commented out code) as unfixable Ignore: - Ignore `E402` on `__init__.py` files and `tests` and `docs` folders
This is auto-fixable
NTFSvolume
added
chore
jbsparrow
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Add new pre-commits
General purpose
toml-sortcheck-merge-conflictname-tests-testcheck-illegal-windows-namescheck-case-conflictThese are for release scripts
check-executables-have-shebangscheck-shebang-scripts-are-executablecheck-added-large-files2. Add new ruff rules
New:
ASYNC#asynccalls that do notawaitanything or use blocking methods (link)FA102# future annotations (link)PTH# usepathlibinstead ofos(link)T20# flake8-print (link)TID# flake8-tidy-imports (link)Changed
TCHwithTC(new name for type checking imports) and add it as a safe fixERA(commented out code) as unfixableIgnore:
E402on__init__.pyfiles,testsanddocsfoldersT20ontestsanddocsfolders3. Update ruff action to v3
Note
The ruff check on this PR may fail cause of the new rules. I will make a PR with the fixes after this PR is merged (if required)