Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove crawler scrape lock #425

Merged
merged 1 commit into from
Jan 5, 2025
Merged

perf: remove crawler scrape lock #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cyberdrop_dl/scraper/crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(self, manager: Manager, domain: str, folder_domain: str | None = No
self.downloader = field(init=False)
self.scraping_progress = manager.progress_manager.scraping_progress
self.client: ScraperClient = field(init=False)
self._lock = asyncio.Lock()
self._semaphore = asyncio.Semaphore(20)

self.domain = domain
self.folder_domain = folder_domain or domain.capitalize()
Expand All @@ -65,7 +65,7 @@ async def run(self, item: ScrapeItem) -> None:
if not item.url.host:
return
self.waiting_items += 1
async with self._lock:
async with self._semaphore:
self.waiting_items -= 1
if item.url.path_qs not in self.scraped_items:
log(f"Scraping: {item.url}", 20)
Expand Down
Loading