Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use deque for file, scrape and sort progress #432

Merged
merged 18 commits into from
Jan 22, 2025
Merged

perf: use deque for file, scrape and sort progress #432

merged 18 commits into from
Jan 22, 2025
+197 −369

Conversation

NTFSvolume
Copy link
Collaborator

@NTFSvolume NTFSvolume commented Jan 5, 2025 •
edited
Loading

  • Use deque to speed up the time it takes to redraw the entire UI. Helps reduce flickering on some terminals

  • Use a base class for file, scrape and sort progress, to reduce code duplication

TODO

  • Apply to hashing progress Progress is too different
  • Apply to sort progress

@NTFSvolume NTFSvolume added the refactor No user facing changes label Jan 5, 2025
@NTFSvolume NTFSvolume changed the title perf: use deque for file and scrape progress perf: use deque for file, scrape, hashing and sort progress Jan 8, 2025
@NTFSvolume
perf: use deque for file and scrape progress
9029046
@NTFSvolume
refactor: create base DequeProgress
5c8b669
@NTFSvolume
refactor: make FileProgress inherit from DequeProgress
7d3c084
@NTFSvolume
refactor: remove unused function
20330bd
@NTFSvolume
fix: missing references
7a8b05c
@NTFSvolume
fix: compute visible tasks
5615b8b
@NTFSvolume
refactor: remove passed parameter
ae8044b 
Only used by scraping_progress
@NTFSvolume
perf: use list comprenhention for visible tasks
351c20f 
faster for short slices
@NTFSvolume
perf: add shortcut for invisible tasks len
c5b1e9b
@NTFSvolume
refactor: remove manager from base DequeProgress
998997c
@NTFSvolume
refactor: reorder properties
e7666b5
@NTFSvolume
refactor: make title a parameter
b1f3b82
@NTFSvolume
refactor: use DequeProgress for sorting
0707384
@NTFSvolume
refactor: move adjust title to deque_progress
4e9dbb5
@NTFSvolume
fix: typechecking errors
866286d
@NTFSvolume
refactor: make some properties private
3169e49
@NTFSvolume
fix: type checking errors
ed45132
@NTFSvolume
refactor: simplify hashing live
b92d3dd
@NTFSvolume NTFSvolume changed the title perf: use deque for file, scrape, hashing and sort progress perf: use deque for file, scrape and sort progress Jan 20, 2025
@NTFSvolume NTFSvolume marked this pull request as ready for review January 20, 2025 15:40
@NTFSvolume NTFSvolume requested a review from jbsparrow January 20, 2025 15:40
@NTFSvolume NTFSvolume mentioned this pull request Jan 21, 2025
Open
jbsparrow
jbsparrow approved these changes Jan 22, 2025
View reviewed changes
Copy link
Owner

@jbsparrow jbsparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! 👍:)

@jbsparrow jbsparrow merged commit 395f29b into jbsparrow:master Jan 22, 2025
3 checks passed
@NTFSvolume NTFSvolume deleted the use_deque branch January 22, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsparrow jbsparrow jbsparrow approved these changes

Assignees
No one assigned
Labels
refactor No user facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NTFSvolume @jbsparrow