Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dates for log management #444

Merged
merged 18 commits into from
Jan 14, 2025
Merged

Conversation

datawhores
Copy link
Collaborator

@datawhores datawhores commented Jan 7, 2025

  1. if rotate_logs is on logs will automatically be put into separate date folders, this will reduce the number of logs in single folder
  2. The user can also reduce logs with max_number_log, without rotate_logs the log files are always overwritten anyways, but if rotate_logs is than logs are deleted for each type to keep them at the max set. The newest logs are kept, and the oldest ones are deleted
  3. If any folder within the log folder, is empty then it will be deleted

Copy link
Collaborator

@NTFSvolume NTFSvolume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add wiki entry for the new setting and what the format should look like. You can just link the documentation of the formats codes for datetime.strftime

cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
@datawhores datawhores requested a review from NTFSvolume January 7, 2025 12:29
@datawhores datawhores marked this pull request as draft January 7, 2025 12:43
@datawhores datawhores marked this pull request as ready for review January 7, 2025 21:05
@datawhores
Copy link
Collaborator Author

@NTFSvolume
I removed the draft status

cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
@datawhores
Copy link
Collaborator Author

datawhores commented Jan 13, 2025

To reduce confusion for the user I use the same settings as caching for how to intepret the values for logs_expires_after

@datawhores datawhores requested a review from NTFSvolume January 13, 2025 04:36
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/global_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/pydantic/validators.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/pydantic/validators.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
cyberdrop_dl/managers/path_manager.py Outdated Show resolved Hide resolved
@datawhores datawhores marked this pull request as draft January 14, 2025 00:03
@datawhores datawhores force-pushed the log-manage branch 14 times, most recently from 29b89e1 to 3e5ecfd Compare January 14, 2025 02:51
@datawhores datawhores force-pushed the log-manage branch 2 times, most recently from b783ba2 to ad77b84 Compare January 14, 2025 03:44
@datawhores
Copy link
Collaborator Author

I tried to clean up the history a little bit

@datawhores datawhores marked this pull request as ready for review January 14, 2025 03:59
@datawhores datawhores requested a review from NTFSvolume January 14, 2025 09:52
Copy link
Collaborator

@NTFSvolume NTFSvolume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There are some duplicate lines
  • The custom_types.py file is duplicated. Delete the original

cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/global_settings.py Outdated Show resolved Hide resolved
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
docs/reference/configuration-options/settings/logs.md Outdated Show resolved Hide resolved
cyberdrop_dl/config_definitions/config_settings.py Outdated Show resolved Hide resolved
@datawhores
Copy link
Collaborator Author

hopefully that clears out the issues, I don't see any dupe lines now

@NTFSvolume NTFSvolume merged commit ce666ed into jbsparrow:master Jan 14, 2025
5 checks passed
@NTFSvolume NTFSvolume added the enhancement New feature or request label Jan 14, 2025
@datawhores datawhores deleted the log-manage branch January 14, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants