-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dates for log management #444
Conversation
datawhores
commented
Jan 7, 2025
•
edited
Loading
edited
- if rotate_logs is on logs will automatically be put into separate date folders, this will reduce the number of logs in single folder
- The user can also reduce logs with max_number_log, without rotate_logs the log files are always overwritten anyways, but if rotate_logs is than logs are deleted for each type to keep them at the max set. The newest logs are kept, and the oldest ones are deleted
- If any folder within the log folder, is empty then it will be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add wiki entry for the new setting and what the format should look like. You can just link the documentation of the formats codes for datetime.strftime
@NTFSvolume |
To reduce confusion for the user I use the same settings as caching for how to intepret the values for logs_expires_after |
29b89e1
to
3e5ecfd
Compare
b783ba2
to
ad77b84
Compare
Co-authored-by: NTFSvolume <[email protected]>
Co-authored-by: NTFSvolume <[email protected]>
ad77b84
to
2525d32
Compare
I tried to clean up the history a little bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are some duplicate lines
- The
custom_types.py
file is duplicated. Delete the original
703336f
to
124cd1e
Compare
Co-authored-by: NTFSvolume <[email protected]>
Co-authored-by: NTFSvolume <[email protected]>
940e769
to
c0e9b4f
Compare
hopefully that clears out the issues, I don't see any dupe lines now |