Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: profiling #478

Merged
merged 13 commits into from
Jan 19, 2025
Merged

test: profiling #478

merged 13 commits into from
Jan 19, 2025

Conversation

NTFSvolume
Copy link
Collaborator

@NTFSvolume NTFSvolume commented Jan 18, 2025 •
edited
Loading

  1. Replace html.parser with lxml I will remove this
  2. Create a folder to store CDL data that will be auto deleted on exit
  3. Create a performance profile report
  4. Copy cookie files to temp AppData folder
  5. Meant for debugging and testing new features
  6. Harcoded to False. Needs to enabled from within the code

I added lxml to improve performance, but the tests showed it wasn't actually faster

TODO

  • Rebase from master
  • Add environment variable to enable profiling
  • Remove lxml

@NTFSvolume NTFSvolume added the refactor No user facing changes label Jan 18, 2025
@NTFSvolume NTFSvolume marked this pull request as ready for review January 18, 2025 00:28
@NTFSvolume NTFSvolume requested a review from jbsparrow January 18, 2025 00:28
@NTFSvolume NTFSvolume merged commit 6ac36f1 into jbsparrow:master Jan 19, 2025
2 checks passed
@NTFSvolume NTFSvolume deleted the profiling branch January 19, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsparrow jbsparrow jbsparrow approved these changes

Assignees
No one assigned
Labels
refactor No user facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NTFSvolume @jbsparrow