Automate readelf and verbosity #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
reviewed
Jan 17, 2025
jcar87
reviewed
Jan 17, 2025
| @@ -54,6 +54,10 @@ def run(cmd): | |||
| f"-DCMAKE_INSTALL_PREFIX={install_dir}/{project} {defines} {shared_cmake} {charmander_header_cmake}") | |||
| run(f"cmake --build {build_dir}/{project} --config Release") | |||
| run(f"cmake --install {build_dir}/{project} --config Release") | |||
| if platform == "windows": | |||
| run(f"{build_dir}/squirtle/Release/hello.exe") | |||
| elif platform == "linux": | |||
There was a problem hiding this comment.
do we want otool -L ... on mac for the same?
There was a problem hiding this comment.
Sure, but I don't have a Mac to test, can be added later, this is the idea
|
Updated with the results of conan-io/conan#17459, now things look good on the linking transitive shared libraries side: (Full details in the README of the PR) |
jcar87
reviewed
Feb 10, 2025
| if self.settings.os == "Linux": | ||
| self.run(f"readelf -d {exe}") | ||
| if self.settings.os == "Windows": | ||
| self.run(f"dumpbin /DEPENDENTS {exe}.exe", env="conanrun") |
There was a problem hiding this comment.
does this work without having to find the tool? (i thought typically this only worked inside a vcvars environment)
There was a problem hiding this comment.
I explicitly added a VCVars(self).generate(scope="run") in the generate() to allow this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And readme with result details