Keep all vary header values when adding Origin #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm thanks! Merging now. |
|
Thanks for merging. Have you planned to make a new release with this fix? |
|
We've a few bugs in the queue to be fixed, and a new round of releases should be issued just after that. It should be within a few weeks from now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a backend response contains multiple values for the Vary header, like "Vary: header1, header2", the resulting Vary header response from haproxy is : "Vary: header2, Origin".
This is linked to this PR : #861
The official documentation states that
req.hdr(orres.hdr) returns "only the last comma-separated value of the header".So it should be
res.fhdrinstead.