Move leader election to a self managed service #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmoraisjr
force-pushed
the
jm-svc-leader
branch
from
f225b0d to
beb4934
Compare
Controller-runtime's leader election works by killing the running process when the leader is lost, consequently being restarted by the runtime env. This works nice for a control plane component, but it'd work badly with haproxy ingress because it currently embeds the data plane as well on its deployment, making haproxy to restart on every instance that looses an election. Controller-runtime behavior is not configurable, so we need to implement our own leader election control.
jcmoraisjr
force-pushed
the
jm-svc-leader
branch
from
beb4934 to
99c1eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller-runtime's leader election works by killing the running process when the leader is lost, consequently being restarted by the runtime env. This works nice for a control plane component, but it'd work badly with haproxy ingress because it currently embeds the data plane as well on its deployment, making haproxy to restart on every instance that looses an election. Controller-runtime behavior is not configurable, so we need to implement our own leader election control.