Add ssl-always-follow-redirect option #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller v0.11 and older had an incorrect behavior compared with ingress spec, regarding HTTPS configuration and SSL redirect. v0.12 added ssl-always-add-https option that adds the host in the HTTPS map when enabled, regardless of the tls attribute configuration. This was a v0.11 and older behavior. This update adds the ability to avoid SSL redirect when TLS was added automatically. This was also a v0.11 and older behavior.
jcmoraisjr
force-pushed
the
jm-follow-ssl-redirect
branch
from
e5449ab to
19d557c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller v0.11 and older had an incorrect behavior compared with ingress spec, regarding HTTPS configuration and SSL redirect.
v0.12 added
ssl-always-add-httpsoption that adds the host in the HTTPS map when enabled, regardless of thetlsattribute configuration. This was a v0.11 and older behavior.This update adds the ability to avoid SSL redirect when TLS was added automatically. This was also a v0.11 and older behavior.