Skip to content

Commit

Permalink
product-details: sanitize sanity_check_firefox_primary_builds (mozill…
Browse files Browse the repository at this point in the history
…a-releng#1593)

There's no use calling sanity_check_firefox_primary_builds with a
version key that it immediately discards.
  • Loading branch information
jcristau authored Dec 16, 2024
1 parent ccdf35e commit 4ef49ca
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions api/src/shipit_api/admin/product_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -1040,9 +1040,6 @@ def get_thunderbird_beta_builds() -> typing.Dict:


def sanity_check_firefox_builds(firefox_versions: FirefoxVersions, firefox_primary_builds: PrimaryBuilds, version_key: str, min_builds: int = 20) -> None:
if version_key in ("FIREFOX_ESR_NEXT", "FIREFOX_AURORA"):
return

version = firefox_versions.get(version_key)
if not version:
return
Expand All @@ -1069,10 +1066,8 @@ def sanity_check_thunderbuild_builds(
def sanity_checks(product_details: ProductDetails) -> None:
for version_key in (
"FIREFOX_NIGHTLY",
"FIREFOX_AURORA",
"FIREFOX_DEVEDITION",
"FIREFOX_ESR",
"FIREFOX_ESR_NEXT",
"FIREFOX_ESR115",
"LATEST_FIREFOX_DEVEL_VERSION",
"LATEST_FIREFOX_RELEASED_DEVEL_VERSION",
Expand Down

0 comments on commit 4ef49ca

Please sign in to comment.