Implement default getName

jd-opensource · Jun 6, 2024 · 50471e7 · 50471e7
1 parent 2552f4b
commit 50471e7
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 21 deletions.
diff --git a/...e-core/joylive-core-api/src/main/java/com/jd/live/agent/core/service/AbstractService.java b/...e-core/joylive-core-api/src/main/java/com/jd/live/agent/core/service/AbstractService.java
@@ -70,6 +70,8 @@ public abstract class AbstractService implements AgentService {
      */
     protected CompletableFuture<Void> stopFuture;
 
+    protected String name;
+
     @Override
     public CompletableFuture<Void> start() {
         int current = status.get();
@@ -170,6 +172,23 @@ public boolean isStarted() {
      *
      * @return A {@link String} representing the name of the service.
      */
-    protected abstract String getName();
+    public String getName() {
+        if (name == null) {
+            String className = this.getClass().getSimpleName();
+            StringBuilder builder = new StringBuilder();
+            int index = 0;
+            for (char c : className.toCharArray()) {
+                if (Character.isUpperCase(c)) {
+                    if (index > 0) {
+                        builder.append("-");
+                    }
+                    builder.append(Character.toLowerCase(c));
+                }
+                index++;
+            }
+            name = builder.toString();
+        }
+        return name;
+    }
 }
 
diff --git a/...le/src/main/java/com/jd/live/agent/implement/service/policy/file/LaneSpaceFileSyncer.java b/...le/src/main/java/com/jd/live/agent/implement/service/policy/file/LaneSpaceFileSyncer.java
@@ -75,11 +75,6 @@ public PolicyType getPolicyType() {
         return PolicyType.LANE_SPACE;
     }
 
-    @Override
-    public String getName() {
-        return "lane-syncer";
-    }
-
     @Override
     protected List<LaneSpace> parse(InputStreamReader reader) {
         return jsonParser.read(reader, new TypeReference<List<LaneSpace>>() {

diff --git a/...le/src/main/java/com/jd/live/agent/implement/service/policy/file/LiveSpaceFileSyncer.java b/...le/src/main/java/com/jd/live/agent/implement/service/policy/file/LiveSpaceFileSyncer.java
@@ -75,11 +75,6 @@ public PolicyType getPolicyType() {
         return PolicyType.LIVE_SPACE;
     }
 
-    @Override
-    public String getName() {
-        return "live-syncer";
-    }
-
     @Override
     protected List<LiveSpace> parse(InputStreamReader reader) {
         return jsonParser.read(reader, new TypeReference<List<LiveSpace>>() {

diff --git a/...file/src/main/java/com/jd/live/agent/implement/service/policy/file/ServiceFileSyncer.java b/...file/src/main/java/com/jd/live/agent/implement/service/policy/file/ServiceFileSyncer.java
@@ -77,11 +77,6 @@ public PolicyType getPolicyType() {
         return PolicyType.SERVICE_POLICY;
     }
 
-    @Override
-    public String getName() {
-        return "service-syncer";
-    }
-
     @Override
     protected CompletableFuture<Void> doStart() {
         publisher.addHandler(handler);

diff --git a/...e/src/main/java/com/jd/live/agent/implement/service/policy/multilive/LiveSpaceSyncer.java b/...e/src/main/java/com/jd/live/agent/implement/service/policy/multilive/LiveSpaceSyncer.java
@@ -93,11 +93,6 @@ public void initialize() {
         template = new Template(syncConfig.getSpaceUrl());
     }
 
-    @Override
-    public String getName() {
-        return "live-space-syncer";
-    }
-
     @Override
     protected SyncConfig getSyncConfig() {
         return syncConfig;