Improve the check for empty ID

jd-opensource · Feb 28, 2025 · 786caa6 · 786caa6
1 parent 70145ed
commit 786caa6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...-api/src/main/java/com/jd/live/agent/governance/service/sync/AbstractLaneSpaceSyncer.java b/...-api/src/main/java/com/jd/live/agent/governance/service/sync/AbstractLaneSpaceSyncer.java
@@ -50,7 +50,7 @@ protected void startSync() throws Exception {
         spaceListSyncer = createSpaceListSyncer();
         Location location = application.getLocation();
         String laneSpaceId = location == null ? null : location.getLaneSpaceId();
-        if (laneSpaceId == null) {
+        if (laneSpaceId == null || laneSpaceId.isEmpty()) {
             syncSpaceList();
         } else {
             syncSpace(laneSpaceId);

diff --git a/...-api/src/main/java/com/jd/live/agent/governance/service/sync/AbstractLiveSpaceSyncer.java b/...-api/src/main/java/com/jd/live/agent/governance/service/sync/AbstractLiveSpaceSyncer.java
@@ -49,11 +49,11 @@ protected void startSync() throws Exception {
         spaceListSubscription = new Subscription<>(getName(), createSpaceListKey(), this::onSpaceListResponse);
         spaceListSyncer = createSpaceListSyncer();
         Location location = application.getLocation();
-        String laneSpaceId = location == null ? null : location.getLiveSpaceId();
-        if (laneSpaceId == null) {
+        String liveSpaceId = location == null ? null : location.getLiveSpaceId();
+        if (liveSpaceId == null || liveSpaceId.isEmpty()) {
             syncSpaceList();
         } else {
-            syncSpace(laneSpaceId);
+            syncSpace(liveSpaceId);
         }
     }
 
@@ -127,7 +127,7 @@ protected void onSpaceListResponse(SyncResponse<List<ApiSpace>> response) {
      * Handles the response from the sync operation for a LiveSpace object.
      *
      * @param response The SyncResponse object containing the response from the sync operation.
-     * @param spaceId The space id.
+     * @param spaceId  The space id.
      */
     protected void onSpaceResponse(SyncResponse<LiveSpace> response, String spaceId) {
         switch (response.getStatus()) {
@@ -168,7 +168,7 @@ protected void updateSpaceList(List<ApiSpace> apiSpaces) {
      * Updates the specified LiveSpace object.
      *
      * @param spaceId The space id.
-     * @param space The LiveSpace object to update.
+     * @param space   The LiveSpace object to update.
      */
     protected void updateSpace(String spaceId, LiveSpace space) {
         if (space == null) {