Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Audio Track #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Tamakimouto
Copy link

It makes sense in a visual novel to have a second audio track for sound effects and voices.
It works by passing an object with a "se" property, as those without will get treated like primary background sources. This will have no effect on those background tracks.

Example:
audio, {src: "se/example", format: ["ogg"], action: "play", se: true},
This plays example.ogg one time, on top of whatever background music is playing.

The docs page is updated too. I got rid of a bunch of extra white space you had in there and changed the default audioLoop value to true, since I think it makes sense for VN bgm to loop. Don't mind the 3rd commit there, GH seems to treat tabs as 8 spaces for me. It's been a few years since you touched this, I know

@jdeisenberg
Copy link
Owner

I like the idea, but what does the attribute "se" stand for? "sound enhancement"? "sound example"? "secondary" "separate"? If we change the attribute to a complete word, it will be easier to understand and remember.

@Tamakimouto
Copy link
Author

It stands for Sound Effect, I could change it to "secondary"; {secondary: true} seems to make sense to me.

And I realize I forgot to put the if statement to check for the attribute in the first place, well its there now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants