Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-in changes #282

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Check-in changes #282

merged 12 commits into from
Aug 16, 2024

Conversation

dmytrokoren
Copy link
Contributor

@dmytrokoren dmytrokoren commented Jul 10, 2024

Modified make_request and changed requests from GET to POST

@jdholtz
Copy link
Owner

jdholtz commented Jul 10, 2024

Thanks for the PR @dmytrokoren. There are multiple different changes in this PR (changing how check-ins are done and better avoidance of 403/429). Could you split this into multiple PRs? You can keep this one for the 403/429 avoidance and make another for the check-in change. It'll make it easier to review each one individually and will help the repo history make more sense and easier to maintain.

Also, it doesn’t look like your branch is up to date with the latest develop changes. It’s missing the new _handle_southwest_error_code in the make_request function.

@dmytrokoren
Copy link
Contributor Author

Thanks for the PR @dmytrokoren. There are multiple different changes in this PR (changing how check-ins are done and better avoidance of 403/429). Could you split this into multiple PRs? You can keep this one for the 403/429 avoidance and make another for the check-in change. It'll make it easier to review each one individually and will help the repo history make more sense and easier to maintain.

Also, it doesn’t look like your branch is up to date with the latest develop changes. It’s missing the new _handle_southwest_error_code in the make_request function.

Sure I'll split it and sync the changes.

@dmytrokoren dmytrokoren changed the title Modifications to Mitigate 429 and 403 Errors 403 avoidance Jul 11, 2024
@dmytrokoren dmytrokoren changed the title 403 avoidance Check-in changes Jul 11, 2024
lib/utils.py Outdated Show resolved Hide resolved
lib/utils.py Outdated Show resolved Hide resolved
@dmytrokoren
Copy link
Contributor Author

This PR is related to #278

lib/utils.py Outdated Show resolved Hide resolved
lib/utils.py Outdated Show resolved Hide resolved
lib/utils.py Outdated Show resolved Hide resolved
lib/utils.py Outdated Show resolved Hide resolved
lib/reservation_monitor.py Outdated Show resolved Hide resolved
dmytrokoren and others added 2 commits August 15, 2024 09:28
The request mocks need to be changed to POST requests as that is what
the Southwest API now uses.
@jdholtz jdholtz merged commit 168e9ce into jdholtz:develop Aug 16, 2024
19 checks passed
@jdholtz
Copy link
Owner

jdholtz commented Aug 16, 2024

Thanks @dmytrokoren!

@dmytrokoren dmytrokoren deleted the develop branch September 21, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants