-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better avoidance of 403/429 #283
base: develop
Are you sure you want to change the base?
Better avoidance of 403/429 #283
Conversation
Modified click action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a Docker image on your repository for this? I think it’d be good to check that this fixes #279 before merging it.
Yes I have updated :develop tag with these new changes. |
@jdholtz can you run :develop tag and see if it works for you, I have made new touch ups. I'll be making new PR or merge to existing!? |
Yes, it's working for me. You can add the new changes here. So it looks like the two parameters (including this change and #274) are using |
Yes, I was running it on Mac docker image and I was getting 403 on first try but then I added incognito and the 403 went away. Might be coincidence but I think it still did the trick. |
Intermittently I do see 403/429 when running multiple times (while testing). Today in docker I'm running 1 account and its running every 4 hours, I did not see any 429 or 403. |
This PR is related to #279 |
any plans to get this merged? 😄 |
@dmytrokoren what is the status on this? I have a check in on Tuesday, and I can use this script and post the logs like last time. |
#It's up to date, with pending PR's. 429 error still coming on login at times. But 403 for me is kind of faded. |
Wait is the issues just for login? I've always used this script by configuring it for reservations, not accounts. |
For me it was mostly login now. If you use reservations you should be fine, most likely will get seats lower B's depends where you flying. |
So you're saying using the account method gives you a better chance at getting a better boarding position? If so, why is that? |
No reservation and login makes no difference. I was just stating the fact that there is still good possibility to get good seats using this script :) depending where you flying to |
Ah. Yep I feel pretty confident as long as the script gets a 200 on the first request. I will post the verbose once I run it in a few days :) |
@dmytrokoren is this ready to be reviewed again or are the 403/429 mitigations still being worked on? |
@jdholtz lets review this PR? |
Modified reservations retry
Still running into following issue:
|
Reverted tests to default
If you are using Raspberry Pi there is no dedicated ARM chromium driver so I believe undetected chromium will not work and you will be detected. |
Update NTP servers and adjust check-in to start earlier (jdholtz#301)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmytrokoren, would it be possible to split this PR into a few different ones? There's 3 major changes happening (cached headers, display in Docker, and retries for failed logins). I'd prefer if these changes could be split up so there aren't as many review comments/changes to make (or time to review them) and each feature can be merged when it's ready rather than needing to wait for all three.
Chromium is installed in Ubuntu ARM versions, which should be sufficient for our purposes. There have been people running this script on ARM architecture without having issues that the Pi is having. Not sure why though... |
- Modified code based on requests.
- Wait time added for reservation_monitor
@dmytrokoren What is the most recent build from your PRs? I got another check in this week and I wanna make sure for when I test it, it's using yours. |
@dmytrokoren Nevermined. The hurricane made our plans change |
Stay safe |
…bdriver_and_updated_requirements
@jdholtz, the current develop branch is working great, but I still occasionally get 429 Too Many Requests errors on login. I'll raise a new pull request to add a retry mechanism to address that. We can hold off on the cached headers for now, as fetching new headers each time is working fine. Let me know how soon you can review new PR? |
Hello, there is a memory leak somewhere. I am using dmytrokoren/auto-southwest-check-in:develop and my memory usage spiked to 6 gig. |
@dmytrokoren I am getting ready to configure the script again. Is |
Modified webdriver and updated requirements