Drop python 3.8 and add official support for Python 3.13 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dict, List, Tuple, etc. (all collection types) are now their lowercase equivalent (dict, list, tuple, etc.) in Python 3.9+
Python 3.9+ now includes the zoneinfo module which provides the same functionality as pytz. This commit removes the dependency on pytz and replaces it with the zoneinfo module.
This was caught by Pylint and should be done instead of f-string formatting.
Windows systems don't have a system timezone database by default, so the zoneinfo module falls back to using the tzdata package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.8 has officially reached its EOL, support for it is dropped. Additionally, official support for Python 3.13 has been added. Here is a list of specific changes done:
zoneinfomoduleI have not found a way to upgrade the Dockerfile past
python:3.12-rc-alpine. If it goes past this tag, the webdriver times out. If I instead switch to an Ubuntu image withpython:3.13-slim, the script is detected very often. We'll have to stay at an old version until we can figure this out.