Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for assembly in partial trust mode #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Nustache.Core/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Security;

// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
Expand Down Expand Up @@ -34,3 +35,5 @@
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.14.0.0")]
[assembly: AssemblyFileVersion("1.14.0.0")]

[assembly: AllowPartiallyTrustedCallers()]
44 changes: 30 additions & 14 deletions Nustache.Core/ValueGetterFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,31 +45,47 @@ protected override void SetItem(int index, ValueGetterFactory item)

public ValueGetter GetValueGetter(object target, string name)
{
return GetValueGetterOrDefault(Items, target, name) ?? new NoValueGetter();
return GetValueGetterOrDefault(Items, target, name, target.GetType()) ?? new NoValueGetter();
}

public ValueGetter GetCompiledGetter(Type targetType, string name)
{
foreach (var factory in Items)
return GetValueGetterOrDefault(Items, null, name, targetType);
}

private static ValueGetter GetValueGetterOrDefault(IList<ValueGetterFactory> factories, object target, string name, Type targetType)
{
List<ValueGetterFactory> factoriesToRemove = null;
foreach (var factory in factories)
{
var getter = factory.GetValueGetter(null, targetType, name);
if (getter != null)
try
{
var getter = factory.GetValueGetter(target, targetType, name);
if (getter != null)
{
return getter;
}
}
catch (System.Security.HostProtectionException)
{
return getter;
//in the event of a partial trust failure, skip the getter factory and mark it for removal
if (factoriesToRemove == null)
{
factoriesToRemove = new List<ValueGetterFactory> { factory };
}
else
{
factoriesToRemove.Add(factory);
}
}
}

return null;
}

private static ValueGetter GetValueGetterOrDefault(IEnumerable<ValueGetterFactory> factories, object target, string name)
{
foreach (var factory in factories)
//remove any getter factories that errored out because of partial trust failure
if (factoriesToRemove != null)
{
var getter = factory.GetValueGetter(target, target.GetType(), name);
if (getter != null)
foreach (var factory in factoriesToRemove)
{
return getter;
factories.Remove(factory);
}
}

Expand Down