Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the two test cases related to typename.
Should we make
__typename
and other type-system related information explicit and required forobject
schemas?I also had to change this line, because it is checking for
ValueInt
value for that argument.Should we add stricter type-checking for our StarWars schema?
Forgive my lack of knowledge, I just started with GraphQL. The Javascript schema-definition API seems very explicit, maybe we should aim for that here as well?