-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #9
base: master
Are you sure you want to change the base?
Improvements #9
Commits on Jun 4, 2017
-
Change birthdays database to YAML / JSON
Parsing plain text files requires more processing than structured file types like YAML / JSON. YAML support is built-into ruby > 1.9.3. The YAML module can easily load a JSON file too. Why was the year field removed? Birthdays are recurring. You need to wish people every year. Why would you want to torment people with the notion of them getting old? 😜
Configuration menu - View commit details
-
Copy full SHA for 8274bc3 - Browse repository at this point
Copy the full SHA 8274bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17a3ea0 - Browse repository at this point
Copy the full SHA 17a3ea0View commit details -
Rename configurations.json to configuration.json.example
because that is what it is - an example / placeholder configuration file
Configuration menu - View commit details
-
Copy full SHA for 726d61a - Browse repository at this point
Copy the full SHA 726d61aView commit details -
Optimize bot to work with {hash}ed birthdays
Supports multiple birthdays from arrays. Earlier version sent multiple wishes for multiple birthdays, this version appends the users to a single array and sends out a single birthday wish message.
Configuration menu - View commit details
-
Copy full SHA for c45e1e1 - Browse repository at this point
Copy the full SHA c45e1e1View commit details -
Configurize mention'ing team members
You can now configure the birthday database with your team memebers' usernames or real names. The bot will mention the users based on this parameter.
Configuration menu - View commit details
-
Copy full SHA for 9f7bc88 - Browse repository at this point
Copy the full SHA 9f7bc88View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfbcc78 - Browse repository at this point
Copy the full SHA dfbcc78View commit details -
Configuration menu - View commit details
-
Copy full SHA for d409122 - Browse repository at this point
Copy the full SHA d409122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 077a104 - Browse repository at this point
Copy the full SHA 077a104View commit details
Commits on Aug 1, 2017
-
The YAML module parses keys with a leading 0 as octcal digits, invalidating 08 and 09. Parsing them as strings would be safer
Configuration menu - View commit details
-
Copy full SHA for 2ee35b3 - Browse repository at this point
Copy the full SHA 2ee35b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b83de9 - Browse repository at this point
Copy the full SHA 9b83de9View commit details
Commits on Aug 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ed5c9cb - Browse repository at this point
Copy the full SHA ed5c9cbView commit details
Commits on Aug 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e901b71 - Browse repository at this point
Copy the full SHA e901b71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4dbfe8 - Browse repository at this point
Copy the full SHA f4dbfe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a0763 - Browse repository at this point
Copy the full SHA e3a0763View commit details
Commits on Nov 21, 2019
-
[refactor] remove httparty dependency
HTTParty is the only gem dependency of the bot. I thought it was redundant to maintain a single dependency especially when it was achievable with the standard net/http library except that it would some extra lines of code. I thought the extra lines of code was worth it rather than having to maintain a single dependency.
Configuration menu - View commit details
-
Copy full SHA for 56c8b07 - Browse repository at this point
Copy the full SHA 56c8b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for e64afd9 - Browse repository at this point
Copy the full SHA e64afd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0596516 - Browse repository at this point
Copy the full SHA 0596516View commit details