Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #9

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Commits on Jun 4, 2017

  1. Change birthdays database to YAML / JSON

    Parsing plain text files requires more processing than
    structured file types like YAML / JSON.
    YAML support is built-into ruby > 1.9.3.
    The YAML module can easily load a JSON file too.
    
    Why was the year field removed?
    Birthdays are recurring. You need to wish people every year.
    Why would you want to torment people with the notion of them getting old? 😜
    shinenelson committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    8274bc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17a3ea0 View commit details
    Browse the repository at this point in the history
  3. Rename configurations.json to configuration.json.example

    because that is what it is - an example / placeholder configuration file
    shinenelson committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    726d61a View commit details
    Browse the repository at this point in the history
  4. Optimize bot to work with {hash}ed birthdays

    Supports multiple birthdays from arrays.
    Earlier version sent multiple wishes for multiple birthdays,
    this version appends the users to a single array
    and sends out a single birthday wish message.
    shinenelson committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    c45e1e1 View commit details
    Browse the repository at this point in the history
  5. Configurize mention'ing team members

    You can now configure the birthday database
    with your team memebers' usernames or real names.
    The bot will mention the users based on this parameter.
    shinenelson committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    9f7bc88 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dfbcc78 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d409122 View commit details
    Browse the repository at this point in the history
  8. Log Time.now

    shinenelson committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    077a104 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2017

  1. change date keys to string

    The YAML module parses keys with a leading 0 as octcal digits,
    invalidating 08 and 09. Parsing them as strings would be safer
    shinenelson committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    2ee35b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b83de9 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. Configuration menu
    Copy the full SHA
    ed5c9cb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. Configuration menu
    Copy the full SHA
    e901b71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4dbfe8 View commit details
    Browse the repository at this point in the history
  3. def build_user_list

    shinenelson committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    e3a0763 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. [refactor] remove httparty dependency

    HTTParty is the only gem dependency of the bot.
    I thought it was redundant to maintain a single
    dependency especially when it was achievable with
    the standard net/http library except that it would
    some extra lines of code.
    I thought the extra lines of code was worth it
    rather than having to maintain a single dependency.
    shinenelson committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    56c8b07 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e64afd9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0596516 View commit details
    Browse the repository at this point in the history