Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augmenting description for nxos_vlan description #29

Conversation

jonasstenling
Copy link
Contributor

Same as PR #21.

@jedelman8
Copy link
Owner

What is this doing for you? What about pycsco? You update proposed but existing needs to be updated to, no?

Can you remove msg in results? You can just add vlan_id to results instead. state is already being returned.

@jonasstenling
Copy link
Contributor Author

This is the commit to add mode=ce or mode=fabricpath. Support (partial, anyways) in pycsco was merged with PR jedelman8/pycsco#9.

Regarding your comment on existing I guess you mean that I need to update nxapi.get_vlan() to also include the current mode of the vlan? I will do that and create a new PR for pycsco.

I can remove the msg in results, it's there for our Tower implementation. In Tower msg is shown as the result of the host task so it's an easy way to communicate the result.

@jonasstenling
Copy link
Contributor Author

I think this is ready to be merged together with jedelman8/pycsco#16.

@jonasstenling
Copy link
Contributor Author

A new PR will be raised against the modules-no-pycsco-utils branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants