Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if entries in session_dir are readable files #65

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

jedrzejboczar
Copy link
Owner

Closes #64.

@josh-nz
Copy link
Contributor

josh-nz commented Jun 13, 2024

I added a similar check in my PR, but for the existence of a file, to make a nicer error message. I'll update my commit 984b34a to use your code.

@josh-nz
Copy link
Contributor

josh-nz commented Jun 14, 2024

Ah, I see your change was in the list function, mine was in the load function. I'll add a review to my change to discuss this further. Disregard my above comment.

@josh-nz josh-nz mentioned this pull request Jun 14, 2024
@jedrzejboczar jedrzejboczar merged commit 5e91dc3 into master Jun 15, 2024
3 checks passed
@jedrzejboczar jedrzejboczar deleted the check-filereadable branch June 15, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E492: Not an editor command: require("telescope").extensions.possession.list()
2 participants