Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop lsp clients plugin #70

Merged

Conversation

josh-nz
Copy link
Contributor

@josh-nz josh-nz commented Jul 6, 2024

This PR extracts the stopping of the LSP clients from the delete_buffers plugin to a separate plugin.

It does introduce possible breaking changes. If a user has delete_buffers set to true, then the LSPs will no longer be stopped since the plugin config defaults to false (which is the same default as delete_buffers).

If we change the LSP default config to true, then it breaks behaviour for those users with delete_buffers set to false. So there is no win.

We could implement a possible config patch if this is desirable. Given the default Neovim behaviour is to do nothing with attached LSPs when you normally delete buffers, I think the default of false is sufficient, and there is no need for a config patch. But the final decision is with you on how to proceed.

Closes #66

@jedrzejboczar
Copy link
Owner

Looks good, thanks for implementing this. I think we can merge it as is, as a breaking change, there is no simple way to prevent it from changing behaviour for some users.

@jedrzejboczar jedrzejboczar merged commit 26afec8 into jedrzejboczar:master Jul 9, 2024
3 checks passed
@josh-nz josh-nz deleted the feature/stop_lsp_plugin branch July 9, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct LSP behaviour when changing sessions?
2 participants