Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the stopping of the LSP clients from the
delete_buffers
plugin to a separate plugin.It does introduce possible breaking changes. If a user has
delete_buffers
set totrue
, then the LSPs will no longer be stopped since the plugin config defaults tofalse
(which is the same default asdelete_buffers
).If we change the LSP default config to
true
, then it breaks behaviour for those users withdelete_buffers
set tofalse
. So there is no win.We could implement a possible config patch if this is desirable. Given the default Neovim behaviour is to do nothing with attached LSPs when you normally delete buffers, I think the default of
false
is sufficient, and there is no need for a config patch. But the final decision is with you on how to proceed.Closes #66