Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): antenna aperture #204

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(lib): antenna aperture #204

merged 2 commits into from
Jan 16, 2025

Conversation

jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added the python Changes Python code label Jan 16, 2025
@github-actions github-actions bot added the tests Changes tests label Jan 16, 2025
@jeertmans jeertmans merged commit 48a93f0 into main Jan 16, 2025
44 of 50 checks passed
@jeertmans jeertmans deleted the fix-aperture branch January 16, 2025 15:58
Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #204 will improve performances by ×310

Comparing fix-aperture (84e9074) with main (30eecd6)

Summary

⚡ 3 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-aperture Change
test_compile_compute_paths 1.5 s 1.1 s +32.45%
test_compute_paths_in_simple_street_canyon_scene[True-20000-0] 959.1 ms 4.9 ms ×190
test_compute_paths_in_simple_street_canyon_scene[True-20000-1] 1,799.9 ms 5.8 ms ×310

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (30eecd6) to head (84e9074).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files          30       30           
  Lines        2506     2506           
=======================================
  Hits         2139     2139           
  Misses        367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Changes Python code tests Changes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant