Merge pull request wolfSSL#708 from ejohnstown/sign-h-rsa

Sign H Casting
jefferyq2 · Oct 29, 2024 · c97a35f · c97a35f
1 parent 6fbfb5c
commit c97a35f
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/internal.c b/src/internal.c
@@ -12473,24 +12473,32 @@ static int SignHRsa(WOLFSSH* ssh, byte* sig, word32* sigSz,
     }
 
     if (ret == WS_SUCCESS) {
-        encSigSz = wc_EncodeSignature(encSig, digest, digestSz,
+        ret = wc_EncodeSignature(encSig, digest, digestSz,
                 wc_HashGetOID(hashId));
-        if (encSigSz <= 0) {
+        if (ret <= 0) {
             WLOG(WS_LOG_DEBUG, "SignHRsa: Bad Encode Sig");
             ret = WS_CRYPTO_FAILED;
         }
+        else {
+            encSigSz = (word32)ret;
+            ret = WS_SUCCESS;
+        }
     }
 
     if (ret == WS_SUCCESS) {
         WLOG(WS_LOG_INFO, "Signing hash with %s.",
             IdToName(ssh->handshake->pubKeyId));
-        *sigSz = wc_RsaSSL_Sign(encSig, encSigSz, sig,
+        ret = wc_RsaSSL_Sign(encSig, encSigSz, sig,
                 KEX_SIG_SIZE, &sigKey->sk.rsa.key,
                 ssh->rng);
-        if (*sigSz <= 0) {
+        if (ret <= 0) {
             WLOG(WS_LOG_DEBUG, "SignHRsa: Bad RSA Sign");
             ret = WS_RSA_E;
         }
+        else {
+            *sigSz = (word32)ret;
+            ret = WS_SUCCESS;
+        }
     }
 
     if (ret == WS_SUCCESS) {