Skip to content

Commit

Permalink
trace2: remove unneeded calls to generate 'def_param' set
Browse files Browse the repository at this point in the history
Now that "trace2_cmd_name()" implicitly calls "trace2_cmd_list_config()"
and "trace2_cmd_list_env_vars()", we don't need to explicitly call them.

Signed-off-by: Jeff Hostetler <[email protected]>
  • Loading branch information
jeffhostetler committed Mar 1, 2024
1 parent 24eee0c commit 7612b3e
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions git.c
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,6 @@ static int handle_alias(int *argcp, const char ***argv)
strvec_pushv(&child.args, (*argv) + 1);

trace2_cmd_alias(alias_command, child.args.v);
trace2_cmd_list_config();
trace2_cmd_list_env_vars();
trace2_cmd_name("_run_shell_alias_");

ret = run_command(&child);
Expand Down Expand Up @@ -411,8 +409,6 @@ static int handle_alias(int *argcp, const char ***argv)
COPY_ARRAY(new_argv + count, *argv + 1, *argcp);

trace2_cmd_alias(alias_command, new_argv);
trace2_cmd_list_config();
trace2_cmd_list_env_vars();

*argv = new_argv;
*argcp += count - 1;
Expand Down Expand Up @@ -462,8 +458,6 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)

trace_argv_printf(argv, "trace: built-in: git");
trace2_cmd_name(p->cmd);
trace2_cmd_list_config();
trace2_cmd_list_env_vars();

validate_cache_entries(the_repository->index);
status = p->fn(argc, argv, prefix);
Expand Down

0 comments on commit 7612b3e

Please sign in to comment.