docs: add ts declaration info #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffijoe
reviewed
Nov 28, 2023
README.md
Outdated
| // awilix.d.ts | ||
| import { AwilixContainer } from "awilix"; | ||
| import { MyServiceA } from "myServiceA.js"; | ||
| import { MyServiceB } from "myServiceB.js"; |
|
Hey @Benzo-Fury, thank you for the PR. I'm not sure if this is something we want to advertise as it might also give a false sense of security. Also, the primary interaction with the library is through dependency injection, where it is completely transparent. I also don't think we want to encourage overriding built-in library types. |
|
All good, no worries. I was just looking into ways to type dependency's with Awilix online and couldn't find much. From experimenting I found this to be the easiest option, but I do appreciate your concern! Thanks anyways 🥰 P.S: Thanks for building Awilix, love the project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.