-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cassandra 2.1 #1
base: cassandra-2.1
Are you sure you want to change the base?
Conversation
Adding the ability to give high tombstone ratio sstages compaction pr…
Adding to comments
As discussed, I think it's a reasonable change. It's unusual to write data to a table with varying TTLs, but it seems relatively low risk. My primary concern is that many people are going to expect the behavior to match other compaction strategies - for that reason, I'm interested in perhaps creating a toggle to allow either this behavior OR the old/established behavior. Do you have a strong opinion on that? |
Sounds completely reasonable. I'll make the change. |
is this irrelevant now? |
@jippi - This is a patch that optimizes TWCS for using varied TTLs in the same Table, and specifically is useful only if you're pushing C*/TWCS so hard that you need to aggressively reclaim disk space as you cross various TTL boundaries. It's not that it's irrelevant, but it's an edge case that doesn't generally apply to most people. I'll merge it when it's cleaned up a bit (or when I have time to clean it up a bit). |
@jeffjirsa i guess this can be closed? |
@jeffjirsa how does this look?