Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_enumerated_attribute fix for integer-based activerecord fields #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

read_enumerated_attribute fix for integer-based activerecord fields #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d99a81
read_enumerated_attribute wasn't handling integer-based activerecord …
AlbertGrimley Apr 27, 2012
dd0484b
few more calls to to_sym needed val.to_s.to_sym
AlbertGrimley Apr 27, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/enumerated_attribute/integrations/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def write_enumerated_attribute(name, val)
return write_attribute(name, val) unless self.class.has_enumerated_attribute?(name)
val = nil if val == ''
val_str = val.to_s if val
val_sym = val.to_sym if val
val_sym = val.to_s.to_sym if val
return instance_variable_set('@'+name, val_sym) unless self.has_attribute?(name)
write_attribute(name, val_str)
val_sym
Expand All @@ -39,7 +39,7 @@ def read_enumerated_attribute(name)
return instance_variable_get('@'+name) unless self.has_attribute?(name)
#this is an enumerated active record attribute
val = read_attribute(name)
val = val.to_sym if !!val
val = val.to_s.to_sym if !!val
val
end

Expand All @@ -57,7 +57,7 @@ def attributes
atts = super
atts.each do |k,v|
if self.class.has_enumerated_attribute?(k)
atts[k] = v.to_sym if v
atts[k] = v.to_s.to_sym if v
end
end
atts
Expand Down