Fix conversation_id renew every time #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this fork I fixed an issue where the dialog with wyoming satellite starts again every time even though the conversation_id is provided.
This was referenced Jul 27, 2024
|
Hi @guinmoon , I've tested the fork, but it doesn't seem to work for me. I'm using the Wyoming satellite with a Raspberry Pi and a Mic 2 HAT. After the first conversation, when I use the wake word again, it starts a new conversation instead of continuing the previous one. |
|
Thx guinmoon, |
jekalmin
reviewed
Nov 12, 2024
| conversation_id = user_input.conversation_id | ||
| if user_input.conversation_id is None: | ||
| conversation_id = ulid.ulid() | ||
| user_input.conversation_id = conversation_id |
There was a problem hiding this comment.
I'm quite not sure if modifying any values(such as conversation_id) in user_input is the right way.
|
Tested this change and it did not work for me using a Wyoming Satellite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this fork I fixed an issue where the dialog with wyoming satellite starts again every time even though the conversation_id is provided.
Related to this.