Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#42] add azure openai (test needed) #48

Merged
merged 3 commits into from
Dec 24, 2023
Merged

[#42] add azure openai (test needed) #48

merged 3 commits into from
Dec 24, 2023

Conversation

jekalmin
Copy link
Owner

Issue

Objective

  • support azure openai

Note

  • test needed (Since I don't have azure openai API, it is not tested yet)

@jekalmin jekalmin self-assigned this Dec 12, 2023
@jekalmin jekalmin marked this pull request as ready for review December 14, 2023 10:32
@AsafMah
Copy link

AsafMah commented Dec 17, 2023

It doesn't work sadly as-is, but I did get it to work:

  1. Validation - sadly the azure openai doesn't have the "models" endpoint, so validation doesn't work. I had to change the code to skip it. Maybe add a checkbox to skip validation?
  2. Azure openai when sending the chat needs the "engine" parameter instead of the "model" parameter, changingthis caused it to work :)
  3. This I can't test because I don't have a regular openai account - but I think you shouldn't pass this parameter if it's not azure (or at least make it not mandatory). A good default to azure BTW is 2023-07-01-preview

@jekalmin
Copy link
Owner Author

jekalmin commented Dec 17, 2023

Thanks for a feedback!
I will apply changes you listed and let you know again!

One question I have is following:

3. This I can't test because I don't have a regular openai account - but I think you shouldn't pass this parameter if it's not azure (or at least make it not mandatory)

Which parameter shouldn't be passed?

@AsafMah
Copy link

AsafMah commented Dec 18, 2023

Thanks for a feedback! I will apply changes you listed and let you know again!

One question I have is following:

  1. This I can't test because I don't have a regular openai account - but I think you shouldn't pass this parameter if it's not azure (or at least make it not mandatory)

Which parameter shouldn't be passed?

Sorry - I meant "api version"

@jekalmin jekalmin changed the base branch from v0.0.9 to v0.0.10 December 24, 2023 08:11
@jekalmin
Copy link
Owner Author

jekalmin commented Dec 24, 2023

@AsafMah
Can you try this again?
I added "skip authentication" and "model_key" for validation and engine parameter.
I released this feature in 0.0.10-beta2 so you can download easily.

skip authentication model key
1 2

@jekalmin jekalmin merged commit d871b60 into v0.0.10 Dec 24, 2023
6 checks passed
@jekalmin jekalmin added this to the 0.0.10 milestone Dec 24, 2023
@jekalmin jekalmin mentioned this pull request Dec 24, 2023
@jekalmin jekalmin deleted the add-azure branch January 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants