Address review feedback

jellyfin · Sep 3, 2023 · 6388e77 · 6388e77
1 parent 819ca47
commit 6388e77
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/app/src/main/assets/native/ExternalPlayerPlugin.js b/app/src/main/assets/native/ExternalPlayerPlugin.js
@@ -141,8 +141,8 @@ export class ExternalPlayerPlugin {
     async getDeviceProfile() {
         return {
             Name: 'Android External Player Stub',
-            MaxStreamingBitrate: 1000000000,
-            MaxStaticBitrate: 1000000000,
+            MaxStreamingBitrate: 1_000_000_000,
+            MaxStaticBitrate: 1_000_000_000,
             DirectPlayProfiles: [{Type: 'Video'}, {Type: 'Audio'}],
             CodecProfiles: [],
             SubtitleProfiles: [{Method: 'Embed'}, {Method: 'Drop'}],

diff --git a/app/src/main/java/org/jellyfin/mobile/bridge/ExternalPlayer.kt b/app/src/main/java/org/jellyfin/mobile/bridge/ExternalPlayer.kt
@@ -167,8 +167,7 @@ class ExternalPlayer(
     }
 
     private fun notifyEvent(event: String, parameters: String = "") {
-        val allowedEvents = arrayOf(Constants.EVENT_CANCELED, Constants.EVENT_ENDED, Constants.EVENT_TIME_UPDATE)
-        if (event in allowedEvents && parameters.isDigitsOnly()) {
+        if (event in ALLOWED_EVENTS && parameters.isDigitsOnly()) {
             webappFunctionChannel.call("window.ExtPlayer.notify$event($parameters)")
         }
     }
@@ -302,4 +301,12 @@ class ExternalPlayer(
             else -> null
         }
     }
+
+    companion object {
+        private val ALLOWED_EVENTS = arrayOf(
+            Constants.EVENT_CANCELED,
+            Constants.EVENT_ENDED,
+            Constants.EVENT_TIME_UPDATE,
+        )
+    }
 }