Allow fields query with get_media_folders #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself in a situation where I needed to get the path corresponding to the top-level media folders. I was able to do this by looking at the source code, realizing it was just an empty call to
self.users("/Items")and then adding the necessary params to specify the extra fields to returns.To facilitate my use-case I added a fields option to
get_media_folders, so runningself.get_media_folders(fields=['Path'])will now return the associated path with each result.I'm not sure if this is the best way to go about it, but it worked for me and now I'm putting it up here as a standalone PR for review / comments.