Identify api #40
Merged
Identify api #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2024
iwalton3
approved these changes
Jan 21, 2024
|
Thanks for taking the time to review / merge these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method to the API, which lets the user access the "identify" feature present in the web client.
It took me much longer to figure out how to do this than this diff would suggest. The jellyfin API is... well its an open source project with a lot of technical dept. I'm not sure how to link to the matrix discussion, but the friendly folks in the "Jellyfin Development" room (#jellyfin-dev:matrix.org) were very helpful. The relevant conversation happened in ~2024-Jan-02 T 04:14 PM.
I've marked this as an "experimental" api, because without a testing mechanism in the repo I feel less confident about it. But I have used it, and it does seem to work.
I would like to add a small test suite to this repo that does a quick automated setup of a jellyfin server, and then tests the API against it. Not sure how difficult that will be, but it's something I'm thinking about.