Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media segment providers to library options #6330

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add media segment providers to library options #6330

merged 1 commit into from
Jan 13, 2025

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Nov 19, 2024 •
edited
Loading

Changes

  • Add a new "media segment providers" section to the library options
  • Requires an API change that fixes a typo in Fix typo in LibraryOptions jellyfin#13097
  • Relies on the server to send the correct available providers for each library type
    • This means our chapter provider shows up for music libraries right now (because audio can have chapters)

Screenshots

91900004a0

Issues

Note: Will cause merge-conflict with #6329 when backporting

@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 19, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 5399ee1
Status ✅ Deployed!
Preview URL https://2b0c9a08.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@jumoog jumoog mentioned this pull request Nov 20, 2024
Merged
@jumoog
Copy link
Contributor

jumoog commented Nov 23, 2024

It think you forgot mixed libraries

@nielsvanvelzen nielsvanvelzen force-pushed the library-options-media-segments branch from c136e3d to ce8b68c Compare November 24, 2024 14:09
@nielsvanvelzen
Copy link
Member Author

It think you forgot mixed libraries

Good catch, I've updated it to not check the library type locally but instead rely on the server to send the accurate providers via the "available options" endpoint.

@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review November 24, 2024 14:12
@nielsvanvelzen nielsvanvelzen requested a review from a team as a code owner November 24, 2024 14:12
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Nov 30, 2024
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@nielsvanvelzen nielsvanvelzen force-pushed the library-options-media-segments branch from ce8b68c to d3ef8f3 Compare December 1, 2024 09:27
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Dec 1, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.7% Duplication on New Code (required ≤ 20%)

See analysis details on SonarQube Cloud

@nielsvanvelzen nielsvanvelzen requested review from a team and removed request for a team January 2, 2025 09:54
@thornbill thornbill added this to the v10.11.0 milestone Jan 10, 2025
@thornbill thornbill added feature New feature or request release-highlight A major new feature for the next release labels Jan 10, 2025
@thornbill thornbill force-pushed the library-options-media-segments branch from d3ef8f3 to 5399ee1 Compare January 13, 2025 17:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
32.7% Duplication on New Code (required ≤ 20%)

See analysis details on SonarQube Cloud

@thornbill thornbill merged commit 26727ed into jellyfin:master Jan 13, 2025
14 of 15 checks passed
@nielsvanvelzen nielsvanvelzen deleted the library-options-media-segments branch January 13, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
feature New feature or request release-highlight A major new feature for the next release
Projects
None yet
Milestone
v10.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nielsvanvelzen @jellyfin-bot @jumoog @thornbill