Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate logs to React #6393

Merged
merged 18 commits into from
Jan 22, 2025
Merged

Migrate logs to React #6393

merged 18 commits into from
Jan 22, 2025

Conversation

viown
Copy link
Member

@viown viown commented Dec 17, 2024

Changes
Migrates the dashboard logs page to React + TS SDK

Issues

@viown viown added the cleanup Cleanup of legacy code or code smells label Dec 17, 2024
@viown viown requested a review from a team as a code owner December 17, 2024 12:56
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 17, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 11da131
Status ✅ Deployed!
Preview URL https://4b99ce4d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown viown marked this pull request as draft December 17, 2024 13:26
@viown viown marked this pull request as ready for review December 17, 2024 14:01
thornbill
thornbill reviewed Dec 17, 2024
View reviewed changes
src/apps/dashboard/routes/logs.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/logs.tsx Outdated Show resolved Hide resolved
@viown viown force-pushed the react-logs branch 3 times, most recently from d076b38 to 972d5f2 Compare January 15, 2025 11:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thornbill thornbill added the typescript PRs or issues relating to TypeScript code label Jan 22, 2025
@thornbill thornbill added this to the v10.11.0 milestone Jan 22, 2025
@thornbill thornbill merged commit 7cec3df into jellyfin:master Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells typescript PRs or issues relating to TypeScript code
Projects
None yet
Milestone
v10.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@viown @jellyfin-bot @thornbill